You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/06/30 06:06:42 UTC

[GitHub] [spark] JoshRosen edited a comment on issue #25016: [SPARK-28200] Decimal overflow handling in ExpressionEncoder

JoshRosen edited a comment on issue #25016: [SPARK-28200] Decimal overflow handling in ExpressionEncoder
URL: https://github.com/apache/spark/pull/25016#issuecomment-507010617
 
 
   jenkins this is ok to test
   
   @mickjermsurawong-stripe, I think we also had a test case for `RowEncoder`? Could you also submit that change (in `RowEncoderSuite.scala`) as part of this PR? Even though we're not actually changing `RowEncoder` behavior here, the old code was lacking explicit test coverage for that path, so it'd be good to pull in that change to strengthen the tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org