You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cactus-dev@jakarta.apache.org by ca...@jakarta.apache.org on 2004/09/19 21:56:37 UTC
[jira] Created: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/CACTUS-143
Here is an overview of the issue:
---------------------------------------------------------------------
Key: CACTUS-143
Summary: ant fails on [checkstyle] task under cygwin due to mixup with newlines
Type: Bug
Status: Unassigned
Priority: Major
Project: Cactus
Assignee:
Reporter: Ralf Hauser
Created: Sun, 19 Sep 2004 12:55 PM
Updated: Sun, 19 Sep 2004 12:55 PM
Environment: cygwin - got cactus HEAD from CVS
Description:
...
[checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
TestSetup.java:0: File does not end with a newline.
BUILD FAILED
C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
ml:43: Following error occured while executing this line
C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
rk\build.xml:627: Got 122 errors.
when doing a
ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
/org/apache/cactus/extension/jetty/TestJettyTestSetup.java
that file no longer shows up.
when doing "cat -vte" this file now ends with
// Ensure that tearDown will shutdown the container^M$
jettyTestSetup.setForceShutdown(true);^M$
} ^M$
}^M$
instead of
// Ensure that tearDown will shutdown the container$
jettyTestSetup.setForceShutdown(true);$
} $
}$
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by ca...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Vincent Massol
Created: Mon, 20 Sep 2004 1:13 AM
Body:
Ralf,
This is supposed to be handled by your CVS client, which will perform the necessary conversions for your platforms. The only case when this does not happen is if the file is flagged as binary which is not the case here.
There is nothing to change in the build.
I'd suggest you perform a new clean checkout, just in case...
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/CACTUS-143?page=comments#action_53227
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/CACTUS-143
Here is an overview of the issue:
---------------------------------------------------------------------
Key: CACTUS-143
Summary: ant fails on [checkstyle] task under cygwin due to mixup with newlines
Type: Bug
Status: Open
Priority: Major
Project: Cactus
Assignee: Vincent Massol
Reporter: Ralf Hauser
Created: Sun, 19 Sep 2004 12:55 PM
Updated: Mon, 20 Sep 2004 1:13 AM
Environment: cygwin - got cactus HEAD from CVS
Description:
...
[checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
TestSetup.java:0: File does not end with a newline.
BUILD FAILED
C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
ml:43: Following error occured while executing this line
C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
rk\build.xml:627: Got 122 errors.
when doing a
ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
/org/apache/cactus/extension/jetty/TestJettyTestSetup.java
that file no longer shows up.
when doing "cat -vte" this file now ends with
// Ensure that tearDown will shutdown the container^M$
jettyTestSetup.setForceShutdown(true);^M$
} ^M$
}^M$
instead of
// Ensure that tearDown will shutdown the container$
jettyTestSetup.setForceShutdown(true);$
} $
}$
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Felipe Leme (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=comments#action_55191 ]
Felipe Leme commented on CACTUS-143:
------------------------------------
PS: here is a list of the failing classes
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\j2ee-13\org\apache\cactus\server\HttpServletRequestWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\j2ee-13\org\apache\cactus\server\PageContextWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\Cookie.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\HttpSessionCookie.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\JspTestCase.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\Request.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\ServletTestCase.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\ServletTestSuite.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\ServletURL.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\WebRequest.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\WebResponse.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\client\authentication\AbstractAuthentication.java:0: File does not end with a newli
ne.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\client\authentication\Authentication.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\client\authentication\BasicAuthentication.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\client\authentication\FormAuthentication.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\AbstractCactusTestCase.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\AbstractTestSuite.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\BaseWebRequest.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\CactusTestCase.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\HttpServiceDefinition.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\RequestDirectives.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\ServiceEnumeration.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\WebRequestImpl.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\WebTestResult.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\AssertionFailedErrorWrapper.java:0: File does not end with a newlin
e.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\ClientException.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\ClientTestCaseCaller.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\ParsingException.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\ServletExceptionWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\WebResponseObjectFactory.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\WebTestResultParser.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\connector\http\AutoReadHttpURLConnection.java:0: File does not end
with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\connector\http\ConnectionHelper.java:0: File does not end with a ne
wline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\connector\http\DefaultHttpClient.java:0: File does not end with a n
ewline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\connector\http\HttpClientConnectionHelper.java:0: File does not end
with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\connector\http\HttpProtocolHandler.java:0: File does not end with a
newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\connector\http\HttpProtocolState.java:0: File does not end with a n
ewline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\client\connector\http\HttpUtil.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\configuration\AbstractWebConfiguration.java:0: File does not end with a ne
wline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\configuration\BaseConfiguration.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\configuration\Configuration.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\configuration\ConfigurationInitializer.java:0: File does not end with a ne
wline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\configuration\DefaultJspConfiguration.java:0: File does not end with a new
line.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\configuration\DefaultServletConfiguration.java:0: File does not end with a
newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\configuration\JspConfiguration.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\configuration\ServletConfiguration.java:0: File does not end with a newlin
e.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\configuration\Version.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\configuration\WebConfiguration.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\AbstractWebImplicitObjects.java:0: File does not end with a newline
.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\AbstractWebTestCaller.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\AbstractWebTestController.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\JspImplicitObjects.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\JspTestCaller.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\JspTestController.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\ServerTestCaseCaller.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\ServletImplicitObjects.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\ServletTestCaller.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\ServletTestController.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\ServletUtil.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\WebImplicitObjects.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\runner\WebappTestRunner.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\runner\WebappTestSuiteLoader.java:0: File does not end with a newli
ne.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\runner\XMLConstants.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\runner\XMLFormatter.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\server\runner\XMLTransformer.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\util\ClassLoaderUtils.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\util\CookieUtil.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\util\IoUtil.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\util\JUnitVersionHelper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\util\StringUtil.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\util\TestCaseImplementChecker.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\util\TestCaseImplementError.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\util\UniqueGenerator.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\internal\util\UrlUtil.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\server\AbstractHttpServletRequestWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\server\AbstractPageContextWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\server\AbstractServletConfigWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\server\AbstractServletContextWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\server\JspTestRedirector.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\server\RequestDispatcherWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\server\ServletTestRedirector.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\server\runner\ServletTestRunner.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\spi\client\ResponseObjectFactory.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\spi\client\connector\ProtocolHandler.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\spi\client\connector\ProtocolState.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\spi\server\ImplicitObjects.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\spi\server\TestController.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\util\ChainedException.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-12-13-14\org\apache\cactus\util\ChainedRuntimeException.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\FilterTestCase.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\extension\jetty\JettyTestSetup.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\extension\jsp\JspTagLifecycle.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\internal\configuration\DefaultFilterConfiguration.java:0: File does not end with a new
line.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\internal\configuration\FilterConfiguration.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\internal\server\FilterImplicitObjects.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\internal\server\FilterTestCaller.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\internal\server\FilterTestController.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\server\AbstractHttpServletRequestWrapper23.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\server\AbstractPageContextWrapper23.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\server\FilterConfigWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\server\FilterTestRedirector.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\server\ServletConfigWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\java\share-13-14\org\apache\cactus\server\ServletContextWrapper.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\TestNoNameTestCase.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\TestServletURL.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\TestShareAll.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\TestWebRequest.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\AbstractTestAbstractCactusTestCase.java:0: File does not end with a newlin
e.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\TestAbstractCactusTestCase.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\TestWebTestResult.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\client\TestWebTestResultParser.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\server\TestServletUtil.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\server\runner\TestXMLFormatter.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\util\TestCookieUtil.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\util\TestIoUtil.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\util\TestStringUtil.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\util\TestTestCaseImplementChecker.java:0: File does not end with a newline
.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\internal\util\TestUniqueGenerator.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\mock\MockHttpURLConnection.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-12-13-14\org\apache\cactus\server\runner\TestServletTestRunner.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-13-14\org\apache\cactus\TestAll.java:0: File does not end with a newline.
[checkstyle] E:\cvs\cactus\felipeal\pristine\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJettyTestSetup.java:0: File does not end with a newline.
BUILD FAILED
E:\cvs\cactus\felipeal\pristine\build.xml:43: The following error occurred while executing this line:
E:\cvs\cactus\felipeal\pristine\framework\build.xml:627: Got 122 errors.
Total time: 15 seconds
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Felipe Leme
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Resolved: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Felipe Leme (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=history ]
Felipe Leme resolved CACTUS-143:
--------------------------------
Resolution: Fixed
Ok, I committed the code (I will double check at home using linux, but it should be fine).
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Felipe Leme
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Reopened: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Felipe Leme (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=history ]
Felipe Leme reopened CACTUS-143:
--------------------------------
Assign To: Felipe Leme (was: Vincent Massol)
OK, I could reproduce the problem: it happens if I do a cvs checkout from cygwin (and run ant from cygwin too) - if I do the checkout from TortoiseCVS, it works fine.
So, one solution for the issue would be documenting the problem and the workaround, but the other one would be fixing each files that fails - I will take a look on this files at home (in a Linux machine) and try to fix them.
Anyway, we need to do something (fix it or document the workaround), so I'm reopening this issue.
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Felipe Leme
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Vincent Massol (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=comments#action_55214 ]
Vincent Massol commented on CACTUS-143:
---------------------------------------
Yep, using the following:
<module name="NewlineAtEndOfFile">
<property name="lineSeparator" value="lf"/>
</module>
works for windows and would also work under unix as in both cases it would end with "lf".
Cool.
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Felipe Leme
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Closed: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Vincent Massol (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=history ]
Vincent Massol closed CACTUS-143:
---------------------------------
Resolution: Cannot Reproduce
Fix Version: 1.7
Thanks Ralf, I am closing this issue for now. I am also using TortoiseCVS and everything's fine here. Dunno what the problem is.
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Vincent Massol
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by ca...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Ralf Hauser
Created: Mon, 20 Sep 2004 1:07 AM
Body:
I also ran "ant" that is mapped to "ant -dist" from what I can see.
I guess the problem is that when using cygwin's CVS upon initial download, it won't convert the linefeeds since it is unix-oriented.
So I guess, the build.xml should try to detect whether it is cygwin or not and if so, it should tell checkstyle to expect unix linefeeds even though it is on windows...
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/CACTUS-143?page=comments#action_53225
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/CACTUS-143
Here is an overview of the issue:
---------------------------------------------------------------------
Key: CACTUS-143
Summary: ant fails on [checkstyle] task under cygwin due to mixup with newlines
Type: Bug
Status: Open
Priority: Major
Project: Cactus
Assignee: Vincent Massol
Reporter: Ralf Hauser
Created: Sun, 19 Sep 2004 12:55 PM
Updated: Mon, 20 Sep 2004 1:07 AM
Environment: cygwin - got cactus HEAD from CVS
Description:
...
[checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
TestSetup.java:0: File does not end with a newline.
BUILD FAILED
C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
ml:43: Following error occured while executing this line
C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
rk\build.xml:627: Got 122 errors.
when doing a
ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
/org/apache/cactus/extension/jetty/TestJettyTestSetup.java
that file no longer shows up.
when doing "cat -vte" this file now ends with
// Ensure that tearDown will shutdown the container^M$
jettyTestSetup.setForceShutdown(true);^M$
} ^M$
}^M$
instead of
// Ensure that tearDown will shutdown the container$
jettyTestSetup.setForceShutdown(true);$
} $
}$
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Vincent Massol (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=comments#action_55202 ]
Vincent Massol commented on CACTUS-143:
---------------------------------------
Felipe, FYI these checkstyle errrors do not exist for me on a windows environment. Maybe they exist on a unix environment (which is what cygwin emulates)? what is strange is that the checkstyle NewlineAtEndOfFile check is documented to work on the different OSes (see http://checkstyle.sourceforge.net/config_misc.html#NewlineAtEndOfFile).
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Felipe Leme
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by ca...@jakarta.apache.org.
The following comment has been added to this issue:
Author: Vincent Massol
Created: Mon, 20 Sep 2004 12:23 AM
Body:
Strange. I don't see any problem here but I'm on windows. Just in case, I've delete and re-added the EOL for the TestJettyTestSetup file.
How do you get this problem? I've just run a "ant dist" in jakarta-cactus/framework
---------------------------------------------------------------------
View this comment:
http://issues.apache.org/jira/browse/CACTUS-143?page=comments#action_53224
---------------------------------------------------------------------
View the issue:
http://issues.apache.org/jira/browse/CACTUS-143
Here is an overview of the issue:
---------------------------------------------------------------------
Key: CACTUS-143
Summary: ant fails on [checkstyle] task under cygwin due to mixup with newlines
Type: Bug
Status: Open
Priority: Major
Project: Cactus
Assignee: Vincent Massol
Reporter: Ralf Hauser
Created: Sun, 19 Sep 2004 12:55 PM
Updated: Mon, 20 Sep 2004 12:23 AM
Environment: cygwin - got cactus HEAD from CVS
Description:
...
[checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
TestSetup.java:0: File does not end with a newline.
BUILD FAILED
C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
ml:43: Following error occured while executing this line
C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
rk\build.xml:627: Got 122 errors.
when doing a
ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
/org/apache/cactus/extension/jetty/TestJettyTestSetup.java
that file no longer shows up.
when doing "cat -vte" this file now ends with
// Ensure that tearDown will shutdown the container^M$
jettyTestSetup.setForceShutdown(true);^M$
} ^M$
}^M$
instead of
// Ensure that tearDown will shutdown the container$
jettyTestSetup.setForceShutdown(true);$
} $
}$
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Ralf Hauser (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=comments#action_55098 ]
Ralf Hauser commented on CACTUS-143:
------------------------------------
I guess the difference is that I start my ant under cygwin
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Vincent Massol
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Ralf Hauser (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=comments#action_55093 ]
Ralf Hauser commented on CACTUS-143:
------------------------------------
got the latest CVS HEAD, but still getting the errors (which was to be expected as per your previous comment). I am using the tortoiseCVS which as you say rightfully is not from cygwin, so there may be a client mismatch.
The only thing is that I havent had the problem so far with the many other tools I have compiled recently. So, feel free to close this issue since i) right now, compiling cactus myself is not a priority for me
ii) if one wants it to be more robust, it is probably not a cactus issue, but a checkstyle issue... and I don't have the time to investigate whether checkstyle could be convinced to be lenient on new line encodings...
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Vincent Massol
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Updated: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Vincent Massol (JIRA)" <ca...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/CACTUS-143?page=history ]
Vincent Massol updated CACTUS-143:
----------------------------------
Component: Other
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://issues.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Components: Other
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Felipe Leme
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Felipe Leme (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=comments#action_55105 ]
Felipe Leme commented on CACTUS-143:
------------------------------------
Vincent/Ralf,
I used to have this issue too, so I will try to reproduce it this afternoon.
-- Felipe
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Vincent Massol
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Vincent Massol (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=comments#action_55084 ]
Vincent Massol commented on CACTUS-143:
---------------------------------------
Ralf, can this issue be closed?
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Vincent Massol
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Vincent Massol (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=comments#action_55203 ]
Vincent Massol commented on CACTUS-143:
---------------------------------------
Ah I think I see the problem. The NewlineAtEndOfFile will check if the file contains the line ending corresponding to the executing platform. Thus it'll fail on unixes as the EOF character used is the one for windows I guess. So maybe we simply need to add the lineSeparator property:
<module name="NewlineAtEndOfFile">
<property name="lineSeparator" value="crlf"/>
</module>
?
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Felipe Leme
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Closed: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Vincent Massol (JIRA)" <ca...@jakarta.apache.org>.
[ http://issues.apache.org/jira/browse/CACTUS-143?page=history ]
Vincent Massol closed CACTUS-143:
---------------------------------
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://issues.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Felipe Leme
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org
[jira] Commented: (CACTUS-143) ant fails on [checkstyle] task under cygwin due to mixup with newlines
Posted by "Felipe Leme (JIRA)" <ca...@jakarta.apache.org>.
[ http://nagoya.apache.org/jira/browse/CACTUS-143?page=comments#action_55206 ]
Felipe Leme commented on CACTUS-143:
------------------------------------
Vincent,
crlf is already the windows style - it must be just lf then. So, if I add the followin on checkstyle.xml it works under cygwin:
<module name="NewlineAtEndOfFile">
<property name="lineSeparator" value="lf"/>
</module>
(that means 'use Unix-style separator')
Could you please set it in yout 'pure windows' environment? (my regular windows is totally cripple - I don't haven even a JAVA_HOME set :-)
-- Felipe
> ant fails on [checkstyle] task under cygwin due to mixup with newlines
> ----------------------------------------------------------------------
>
> Key: CACTUS-143
> URL: http://nagoya.apache.org/jira/browse/CACTUS-143
> Project: Cactus
> Type: Bug
> Environment: cygwin - got cactus HEAD from CVS
> Reporter: Ralf Hauser
> Assignee: Felipe Leme
> Fix For: 1.7
>
> ...
> [checkstyle] C:\Documents and Settings\r\My Documents\psph\workspace\c
> actus\framework\src\test\share-13-14\org\apache\cactus\extension\jetty\TestJetty
> TestSetup.java:0: File does not end with a newline.
> BUILD FAILED
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\build.x
> ml:43: Following error occured while executing this line
> C:\Documents and Settings\r\My Documents\psph\workspace\cactus\framewo
> rk\build.xml:627: Got 122 errors.
> when doing a
> ralf@pc:~/<1>workspace/cactus> u2d framework/src/test/share-13-14
> /org/apache/cactus/extension/jetty/TestJettyTestSetup.java
> that file no longer shows up.
> when doing "cat -vte" this file now ends with
> // Ensure that tearDown will shutdown the container^M$
> jettyTestSetup.setForceShutdown(true);^M$
> } ^M$
> }^M$
> instead of
> // Ensure that tearDown will shutdown the container$
> jettyTestSetup.setForceShutdown(true);$
> } $
> }$
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://nagoya.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: cactus-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: cactus-dev-help@jakarta.apache.org