You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2026/09/06 14:06:42 UTC

[PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

sfirke opened a new pull request, #43940:
URL: https://github.com/apache/superset/pull/43940

   ### SUMMARY
   Currently when you have a single set of dashboard tabs, as you scroll down, the tabs are frozen to the top, providing the desired UX. But this does not currently apply to _nested_ tabs. This PR fixes that, adding two behaviors to nested tabs:
   1. They get stuck to the top
   2. When you click between nested tabs, there's now auto-scroll to the top. This problem was not evident until I fixed (1).
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   **BEFORE (master branch 2026-09-04)**
   
   Note that I've scrolled down and the 2nd-level tabs have disappeared:
   
   <img width="943" height="452" alt="nested_tabs_frozen_before" src="https://github.com/user-attachments/assets/fb2afba8-807a-40b5-9071-0a46730b2a25" />
   
   
   **AFTER:**
   
   I have again scrolled down, now the 2nd level tabs are frozen and visible:
   
   <img width="938" height="486" alt="nested_tabs_frozen_after" src="https://github.com/user-attachments/assets/8f03f4da-a697-4b51-b32a-e4ab83387c7f" />
   
   Here I have scrolled down into content on a third level of tabs, still works:
   <img width="971" height="318" alt="image" src="https://github.com/user-attachments/assets/7a7e7160-9212-496c-ac0c-199594ef4298" />
   
   
   ### TESTING INSTRUCTIONS
   
   Create a dashboard with multiple levels of tabs, observe that they get stuck to the top when scrolling down and that clicking between nested tabs jumps you up to the top. I manually tested both.
   
   ### ADDITIONAL INFORMATION
   - [X] Changes UI
   
   I bounced this idea off of @rusackas a couple of months ago.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #43940:
URL: https://github.com/apache/superset/pull/43940#discussion_r3962078290


##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.test.tsx:
##########
@@ -263,5 +264,117 @@ describe('TabsRenderer', () => {
     expect(container).toHaveStyleRule('cursor', 'move', {
       target: '.dragdroppable-tab *',
     });
+
+    // Release the pointer so the drag does not outlive this test. dnd-kit
+    // keeps swallowing clicks on the shared document for 50ms after a drag
+    // ends, which would eat the tab click of whichever test runs next.
+    fireEvent.pointerUp(document, { button: 0, isPrimary: true, clientX: 50 });
+    await sleep(60);
+  });
+
+  // jsdom's cascade ignores specificity, so assert on the emotion rule rather
+  // than the computed style, which antd's own `position: relative` would win
+  const TAB_BAR = { target: /> ?\.ant-tabs ?> ?\.ant-tabs-nav$/ };
+
+  test('pins the tab bar below the offset supplied by the dashboard', () => {
+    render(
+      <StickyTabsOffsetContext.Provider value={64}>
+        <TabsRenderer {...mockProps} />
+      </StickyTabsOffsetContext.Provider>,
+    );
+    const container = screen.getByTestId('dashboard-component-tabs');
+
+    expect(container).toHaveStyleRule('position', 'sticky', TAB_BAR);
+    expect(container).toHaveStyleRule('top', '64px', TAB_BAR);
+  });
+
+  test('leaves the tab bar in document flow without a dashboard offset', () => {
+    render(<TabsRenderer {...mockProps} />);
+    const container = screen.getByTestId('dashboard-component-tabs');
+
+    expect(container).not.toHaveStyleRule('position', 'sticky', TAB_BAR);
+  });
+
+  test('leaves the tab bar in document flow in edit mode', () => {
+    render(
+      <StickyTabsOffsetContext.Provider value={64}>
+        <TabsRenderer {...mockProps} editMode />
+      </StickyTabsOffsetContext.Provider>,
+    );
+    const container = screen.getByTestId('dashboard-component-tabs');
+
+    expect(container).not.toHaveStyleRule('position', 'sticky', TAB_BAR);
+  });
+
+  test('stacks nested tab bars beneath its own tab bar', () => {

Review Comment:
   The child offset now depends on `ResizeObserver`, but this only asserts the initial height. When a parent tab bar reflows after mount (for example after font loading or a narrow viewport wraps labels), a stale child offset lets sticky bars overlap. Could this trigger the observer after changing the measured height and assert the descendant offset updates?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43940:
URL: https://github.com/apache/superset/pull/43940#issuecomment-5602979034

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | a2cd84e2cc62d33d50b5343aa51425f2defa0943 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aa16378b4730a0008761e60 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43940--superset-docs-preview.netlify.app](https://deploy-preview-43940--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQzOTQwLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.RDEhkGjw7IOATf88ufj1IcOHGKQetIIkRr2cIfv_4l0)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcoxDoAgDADAv3SWWKMB4w98RqE1GhUIdDHGv8t2w72QS7qzwgLQgS8Uw968CWnPVHefqLCpeoTzMVGqChslX1tmyVd6Vm7dEg12dLOf3IiEiLOzg1iE7wc) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-43940--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on code in PR #43940:
URL: https://github.com/apache/superset/pull/43940#discussion_r3969532694


##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -774,6 +776,17 @@ const DashboardBuilder = () => {
     ? theme.sizeUnit * 4
     : theme.sizeUnit * 8;
 
+  // Tab bars nested in the grid pin just below the sticky header while the
+  // page scrolls. Not in the mobile viewport, where the header scrolls away
+  // and the mobile styling pins tab bars on its own; not in report mode,
+  // whose tiled screenshots scroll the page and would capture a pinned bar
+  // in every tile; and not while a chart is maximized, which sits inside its
+  // own stacking context and must not be covered by a pinned bar.
+  // (TabsRenderer itself opts out while editing, since drop targets rely on
+  // document flow.)
+  const stickyTabsOffset =
+    isMobileViewport || isReport || fullSizeChartId ? undefined : barTopOffset;

Review Comment:
   Human Sam here: I haven't used `MOBILE_CONSUMPTION_MODE` at all, but it looks like it will be useful to my deployment. Just saying that I haven't done any manual testing or QA of the mobile implications here, but I would be willing to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on code in PR #43940:
URL: https://github.com/apache/superset/pull/43940#discussion_r3966432396


##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -774,6 +776,17 @@ const DashboardBuilder = () => {
     ? theme.sizeUnit * 4
     : theme.sizeUnit * 8;
 
+  // Tab bars nested in the grid pin just below the sticky header while the
+  // page scrolls. Not in the mobile viewport, where the header scrolls away
+  // and the mobile styling pins tab bars on its own; not in report mode,
+  // whose tiled screenshots scroll the page and would capture a pinned bar
+  // in every tile; and not while a chart is maximized, which sits inside its
+  // own stacking context and must not be covered by a pinned bar.
+  // (TabsRenderer itself opts out while editing, since drop targets rely on
+  // document flow.)
+  const stickyTabsOffset =
+    isMobileViewport || isReport || fullSizeChartId ? undefined : barTopOffset;

Review Comment:
   The desktop path stacks nested bars, but this disables that offset propagation on mobile while the mobile CSS in `TabsRenderer` gives every `.ant-tabs-nav` `top: 0`. On a dashboard with nested tab sets, the parent and child bars therefore become sticky at the same viewport position, and the inner bar covers the parent once it reaches the top. Could we keep propagating measured bar heights on mobile (starting from the mobile top-level bar's height), or add an equivalent mobile-specific offset path? A narrow-viewport nested-tabs test would help pin down the expected stacking.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on code in PR #43940:
URL: https://github.com/apache/superset/pull/43940#discussion_r3969162081


##########
superset-frontend/src/dashboard/components/gridComponents/TabsRenderer/TabsRenderer.test.tsx:
##########
@@ -263,5 +264,117 @@ describe('TabsRenderer', () => {
     expect(container).toHaveStyleRule('cursor', 'move', {
       target: '.dragdroppable-tab *',
     });
+
+    // Release the pointer so the drag does not outlive this test. dnd-kit
+    // keeps swallowing clicks on the shared document for 50ms after a drag
+    // ends, which would eat the tab click of whichever test runs next.
+    fireEvent.pointerUp(document, { button: 0, isPrimary: true, clientX: 50 });
+    await sleep(60);
+  });
+
+  // jsdom's cascade ignores specificity, so assert on the emotion rule rather
+  // than the computed style, which antd's own `position: relative` would win
+  const TAB_BAR = { target: /> ?\.ant-tabs ?> ?\.ant-tabs-nav$/ };
+
+  test('pins the tab bar below the offset supplied by the dashboard', () => {
+    render(
+      <StickyTabsOffsetContext.Provider value={64}>
+        <TabsRenderer {...mockProps} />
+      </StickyTabsOffsetContext.Provider>,
+    );
+    const container = screen.getByTestId('dashboard-component-tabs');
+
+    expect(container).toHaveStyleRule('position', 'sticky', TAB_BAR);
+    expect(container).toHaveStyleRule('top', '64px', TAB_BAR);
+  });
+
+  test('leaves the tab bar in document flow without a dashboard offset', () => {
+    render(<TabsRenderer {...mockProps} />);
+    const container = screen.getByTestId('dashboard-component-tabs');
+
+    expect(container).not.toHaveStyleRule('position', 'sticky', TAB_BAR);
+  });
+
+  test('leaves the tab bar in document flow in edit mode', () => {
+    render(
+      <StickyTabsOffsetContext.Provider value={64}>
+        <TabsRenderer {...mockProps} editMode />
+      </StickyTabsOffsetContext.Provider>,
+    );
+    const container = screen.getByTestId('dashboard-component-tabs');
+
+    expect(container).not.toHaveStyleRule('position', 'sticky', TAB_BAR);
+  });
+
+  test('stacks nested tab bars beneath its own tab bar', () => {

Review Comment:
   Good catch, this was a genuine coverage gap — fixed in a2cd84e.
   
   The behavior itself was already correct: `measure` is wired as the `ResizeObserver` callback, so a reflow calls `setTabBarHeight`, which re-renders and pushes a fresh `childStickyOffset` through the context provider. But the test never proved it. Our shared jsdom shim (`spec/helpers/ResizeObserver.ts`) is a no-op whose `observe()` returns `null`, so `stacks nested tab bars beneath its own tab bar` only ever exercised the initial synchronous `measure()`.
   
   I added `restacks nested tab bars when its own tab bar reflows`, which stands in an observer that hands its callback back to the test, asserts the initial `104`, then grows the measured bar to 80 and fires the callback to assert the descendant offset follows to `144`. I checked it fails for the right reason by breaking the callback wiring locally.
   
   One correction to the bot's suggestion for anyone following along: `measure` ignores the observer entries and re-reads `tabBar.offsetHeight`, so the test has to move the `offsetHeight` spy and *then* invoke the callback — passing a new `DOMRect` in wouldn't have asserted anything.
   
   While in there I also guarded the observer construction the way the sticky header's own effect in `DashboardBuilder` does, so an environment without `ResizeObserver` keeps the height measured at mount rather than throwing.
   
   ---
   🤖 _Drafted by Claude Code, co-signed by @sfirke._



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on PR #43940:
URL: https://github.com/apache/superset/pull/43940#issuecomment-5560060365

   Is Bito AI having a problem? Should have reviewed this I think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43940:
URL: https://github.com/apache/superset/pull/43940#issuecomment-5591599249

   <!-- Bito Reply -->
   The current implementation in the test suite uses a static mock for `getBoundingClientRect` to assert the initial height. To address scenarios where the parent tab bar reflows after mount, you can trigger the `ResizeObserver` by manually invoking the callback registered with the observer. In your test, you would need to capture the `ResizeObserver` instance (e.g., by mocking `window.ResizeObserver`) and then call its callback with a new `DOMRect` representing the updated height to verify that the descendant offset updates correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #43940:
URL: https://github.com/apache/superset/pull/43940#issuecomment-5559771290

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | a5a9f7232d98511dc257acaa62f4b2a0d1bc7a1b |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a9d7373526f0900087108ee |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-43940--superset-docs-preview.netlify.app](https://deploy-preview-43940--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQzOTQwLS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.RDEhkGjw7IOATf88ufj1IcOHGKQetIIkRr2cIfv_4l0)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcrLDYAgDADQXXqWWDWKuoFjFFuj8QOBXohxd7m9w3shRH8HhRmgAhfpWffiTUhrprQ7T5FN0mM9s3kkqbBRcqlklnD5vHDpA01sO9v17bDhhIijbXAUge8H) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-43940--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on code in PR #43940:
URL: https://github.com/apache/superset/pull/43940#discussion_r3969164021


##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardBuilder.tsx:
##########
@@ -774,6 +776,17 @@ const DashboardBuilder = () => {
     ? theme.sizeUnit * 4
     : theme.sizeUnit * 8;
 
+  // Tab bars nested in the grid pin just below the sticky header while the
+  // page scrolls. Not in the mobile viewport, where the header scrolls away
+  // and the mobile styling pins tab bars on its own; not in report mode,
+  // whose tiled screenshots scroll the page and would capture a pinned bar
+  // in every tile; and not while a chart is maximized, which sits inside its
+  // own stacking context and must not be covered by a pinned bar.
+  // (TabsRenderer itself opts out while editing, since drop targets rely on
+  // document flow.)
+  const stickyTabsOffset =
+    isMobileViewport || isReport || fullSizeChartId ? undefined : barTopOffset;

Review Comment:
   You're right that nested tab bars overlap on mobile, and thanks for reading the interaction between the two paths carefully — but I don't think it belongs in this PR.
   
   That mobile rule predates this change: `git blame` puts it at 6211f9936b (#37141, mobile consumption mode). Because it targets `.ant-tabs-nav` as a descendant rather than a direct child, every nested bar already pins at `top: 0` on master today, with or without this PR. Nothing here makes it worse — the only mobile-adjacent change is extracting `useIsMobile()` into a named variable so it can be read twice. And it's reachable only with `MOBILE_CONSUMPTION_MODE` enabled.
   
   Propagating measured heights on mobile is also more than a parameter change. On mobile the top-level tab bar is pinned by the media query and renders outside the `StickyTabsOffsetContext.Provider`, which wraps only `DashboardContainer` — so there's no measured root to stack from. A real fix means measuring the top-level bar, seeding the context with that height instead of `undefined` on mobile, and reworking the mobile rule to consume `stickyTop` with a direct-child selector. That's a change to the mobile consumption feature's own styling, and I'd rather not fold it into a desktop-nested-tabs PR where it can't get the mobile review attention it deserves.
   
   I'll open a follow-up issue for it and cc @rusackas, so the narrow-viewport nested-tabs test you're asking for can land alongside the fix rather than ahead of it.
   
   ---
   🤖 _Drafted by Claude Code, co-signed by @sfirke._



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43940:
URL: https://github.com/apache/superset/pull/43940#issuecomment-5613665432

   **Bito Automatic Review Skipped – PR Already Merged**<br/><br/>Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.<br/>No action is needed if you didn't intend to review it. To get a review, you can type `/review` in a comment and save it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43940:
URL: https://github.com/apache/superset/pull/43940#issuecomment-5559755062

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #43940:
URL: https://github.com/apache/superset/pull/43940#issuecomment-5559833378

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/43940?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 79.82%. Comparing base ([`18d277c`](https://app.codecov.io/gh/apache/superset/commit/18d277c096d6fbe9cf397a695ca2f418d7f4b6f9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4ffade0`](https://app.codecov.io/gh/apache/superset/commit/4ffade0b6346998333e47be56e27780f6ed557ae?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #43940      +/-   ##
   ==========================================
   + Coverage   79.81%   79.82%   +0.01%     
   ==========================================
     Files        2913     2914       +1     
     Lines      170345   170376      +31     
     Branches    39491    39501      +10     
   ==========================================
   + Hits       135962   136005      +43     
   + Misses      31861    31849      -12     
     Partials     2522     2522              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/43940/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/43940/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.37% <100.00%> (+0.02%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/43940?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #43940:
URL: https://github.com/apache/superset/pull/43940#issuecomment-5560805659

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers an incremental AI Review.
   - `/review full` - Manually triggers a full AI Review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] fix(dashboard): freeze nested tabs to the top when scrolling down [superset]

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke merged PR #43940:
URL: https://github.com/apache/superset/pull/43940


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org