[GitHub] [druid] isandeep41 commented on a change in pull request #11431: removes unnecessary checks

[GitBox <gi...@apache.org>]

isandeep41 commented on a change in pull request #11431:
URL: https://github.com/apache/druid/pull/11431#discussion_r667438886



##########
File path: extensions-core/lookups-cached-single/src/main/java/org/apache/druid/server/lookup/PollingLookup.java
##########
@@ -132,9 +132,7 @@ public String apply(@Nullable String key)
       return NullHandling.emptyToNullIfNeeded((String) cache.get(keyEquivalent));
     }
     finally {
-      if (cacheRefKeeper != null && cache != null) {

Review comment:
       it seems the code block is not dependent on cache, but I have included the `cache != null` check 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org