You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/07/18 07:38:16 UTC
Review Request 50120: LENS-1030 : Fix logs flowing in query logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50120/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1030
https://issues.apache.org/jira/browse/LENS-1030
Repository: lens
Description
-------
Changes include :
- Removing MDC ids from grizzly threads upon response : Side effect of this removed ids from lensserver-requests logs. (Earlier lensserver-requests.log was having wrong id on request and correct id on response)
- Added log with logging filter id sothat we can cross check logs from lensserver-requests logs.
Diffs
-----
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java 7780dff
lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java e982520
lens-server/src/main/java/org/apache/lens/server/BaseApp.java 19de31c
lens-server/src/main/java/org/apache/lens/server/LensApplication.java bace84d
lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java d2f2f91
lens-server/src/main/java/org/apache/lens/server/LensRequestLoggingFilter.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2de098d
lens-server/src/main/resources/lensserver-default.xml 6dc322e
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java fe9163f
src/site/apt/admin/config.apt 5b76069
Diff: https://reviews.apache.org/r/50120/diff/
Testing
-------
Verified query logs are not dumped with other logs.
This is how the log in lensserver looks now for a request :
18 Jul 2016 06:34:06 [7a6e3c3d-8f4a-46c6-813b-26c55ab5e484] [grizzly-http-server-3] INFO org.apache.lens.server.LensRequestLoggingFilter - Request from user: null , path=metastore/storages loggingFilter ID=4
Thanks,
Amareshwari Sriramadasu
Re: Review Request 50120: LENS-1030 : Fix logs flowing in query logs
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50120/#review142545
-----------------------------------------------------------
Ship it!
Ship It!
- Rajat Khandelwal
On July 18, 2016, 1:08 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50120/
> -----------------------------------------------------------
>
> (Updated July 18, 2016, 1:08 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1030
> https://issues.apache.org/jira/browse/LENS-1030
>
>
> Repository: lens
>
>
> Description
> -------
>
> Changes include :
> - Removing MDC ids from grizzly threads upon response : Side effect of this removed ids from lensserver-requests logs. (Earlier lensserver-requests.log was having wrong id on request and correct id on response)
> - Added log with logging filter id sothat we can cross check logs from lensserver-requests logs.
>
>
> Diffs
> -----
>
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java 7780dff
> lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java e982520
> lens-server/src/main/java/org/apache/lens/server/BaseApp.java 19de31c
> lens-server/src/main/java/org/apache/lens/server/LensApplication.java bace84d
> lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java d2f2f91
> lens-server/src/main/java/org/apache/lens/server/LensRequestLoggingFilter.java PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2de098d
> lens-server/src/main/resources/lensserver-default.xml 6dc322e
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java fe9163f
> src/site/apt/admin/config.apt 5b76069
>
> Diff: https://reviews.apache.org/r/50120/diff/
>
>
> Testing
> -------
>
> Verified query logs are not dumped with other logs.
>
> This is how the log in lensserver looks now for a request :
> 18 Jul 2016 06:34:06 [7a6e3c3d-8f4a-46c6-813b-26c55ab5e484] [grizzly-http-server-3] INFO org.apache.lens.server.LensRequestLoggingFilter - Request from user: null , path=metastore/storages loggingFilter ID=4
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 50120: LENS-1030 : Fix logs flowing in query logs
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50120/
-----------------------------------------------------------
(Updated July 19, 2016, 7:23 a.m.)
Review request for lens.
Changes
-------
tests and checkstyle fixed
Bugs: LENS-1030
https://issues.apache.org/jira/browse/LENS-1030
Repository: lens
Description
-------
Changes include :
- Removing MDC ids from grizzly threads upon response : Side effect of this removed ids from lensserver-requests logs. (Earlier lensserver-requests.log was having wrong id on request and correct id on response)
- Added log with logging filter id sothat we can cross check logs from lensserver-requests logs.
Diffs (updated)
-----
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java 7780dff
lens-server/src/main/java/org/apache/lens/server/AuthenticationFilter.java e982520
lens-server/src/main/java/org/apache/lens/server/BaseApp.java 19de31c
lens-server/src/main/java/org/apache/lens/server/LensApplication.java bace84d
lens-server/src/main/java/org/apache/lens/server/LensRequestContextInitFilter.java d2f2f91
lens-server/src/main/java/org/apache/lens/server/LensRequestLoggingFilter.java PRE-CREATION
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 2de098d
lens-server/src/main/resources/lensserver-default.xml 6dc322e
lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java fe9163f
lens-server/src/test/resources/lens-site.xml 64e83be
src/site/apt/admin/config.apt 5b76069
Diff: https://reviews.apache.org/r/50120/diff/
Testing
-------
Verified query logs are not dumped with other logs.
This is how the log in lensserver looks now for a request :
18 Jul 2016 06:34:06 [7a6e3c3d-8f4a-46c6-813b-26c55ab5e484] [grizzly-http-server-3] INFO org.apache.lens.server.LensRequestLoggingFilter - Request from user: null , path=metastore/storages loggingFilter ID=4
Thanks,
Amareshwari Sriramadasu