You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/04/11 10:14:52 UTC

svn commit: r1888614 - /pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ZoomMenu.java

Author: tilman
Date: Sun Apr 11 10:14:52 2021
New Revision: 1888614

URL: http://svn.apache.org/viewvc?rev=1888614&view=rev
Log:
PDFBOX-4892: simplify code, as suggested by valerybokov

Modified:
    pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ZoomMenu.java

Modified: pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ZoomMenu.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ZoomMenu.java?rev=1888614&r1=1888613&r2=1888614&view=diff
==============================================================================
--- pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ZoomMenu.java (original)
+++ pdfbox/branches/2.0/debugger/src/main/java/org/apache/pdfbox/debugger/ui/ZoomMenu.java Sun Apr 11 10:14:52 2021
@@ -88,17 +88,17 @@ public final class ZoomMenu extends Menu
      */
     public void changeZoomSelection(float zoomValue)
     {
-        String selection = (int)(zoomValue*100) +"%";
+        int selection = (int) (zoomValue * 100);
         for (Component comp : menu.getMenuComponents())
         {
-            JRadioButtonMenuItem menuItem = (JRadioButtonMenuItem) comp;
-            if (menuItem.getText().equals(selection))
+            ZoomMenuItem menuItem = (ZoomMenuItem) comp;
+            if (menuItem.zoom == selection)
             {
                 menuItem.setSelected(true);
                 return;
             }
         }
-        throw new IllegalArgumentException("no zoom menu item found for: " + selection);
+        throw new IllegalArgumentException("no zoom menu item found for: " + selection + "%");
     }
 
     /**