You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2023/04/11 13:44:38 UTC

[GitHub] [arrow] jorisvandenbossche commented on issue #34890: [Python] Function 'dictionary_encode' fails with DictionaryArray input (for compute kernel / ChunkedArray method)

jorisvandenbossche commented on issue #34890:
URL: https://github.com/apache/arrow/issues/34890#issuecomment-1503383158

   Indeed, and the other `dictionary_encode()` methods (on base class Array and on ChunkedArray) call the compute kernel, and hence give this error. Doing that for DictionaryArray.dictionary_encode as well sounds fine to me.
   
   If we want to have support for passing a DictionaryArray to the "dictionary_encode" kernel generally, this is done in C++, and would require registering an extra version of this kernel (as a no-op for dict typed input). It seems there is actually a comment about this:
   
   https://github.com/apache/arrow/blob/e488942cd552ac36a46d40477c1b0326a626ed98/cpp/src/arrow/compute/kernels/vector_hash.cc#L810-L817
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org