You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/06/12 14:05:23 UTC

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #1231: Fix the some mode priviliges when registring a driver

Ouss4 opened a new pull request #1231:
URL: https://github.com/apache/incubator-nuttx/pull/1231


   ## Summary
   Fix some drivers mode privileges.  It's not used but it's better to get it right.
   
   ## Impact
   The change should have no impact.
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 removed a comment on pull request #1231: Fix the mode priviliges when registring a driver

Posted by GitBox <gi...@apache.org>.
Ouss4 removed a comment on pull request #1231:
URL: https://github.com/apache/incubator-nuttx/pull/1231#issuecomment-643291020


   The mixed case errors are register names that are probably called that way in the datasheet, so I didn't want to change them.
   The long line could be fixed by making the struct's name shorter, but that's exported outside the driver and used in applications, which would cost someone a second or two to fix it.
   Breaking the line doesn't look any better.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #1231: Fix the mode priviliges when registring a driver

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #1231:
URL: https://github.com/apache/incubator-nuttx/pull/1231#issuecomment-643291020


   The mixed case errors are register names that are probably called that way in the datasheet, so I didn't want to change them.
   The long line could be fixed by making the struct's name shorter, but that's exported outside the driver and used in applications, which would cost someone a second or two to fix it.
   Breaking the line doesn't look any better.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis merged pull request #1231: Fix the mode priviliges when registring a driver

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #1231:
URL: https://github.com/apache/incubator-nuttx/pull/1231


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org