You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2023/01/19 17:48:00 UTC

[jira] [Comment Edited] (CASSANDRA-18139) Revert changes to units output in FileUtils#stringifyFileSize post CASSANDRA-15234

    [ https://issues.apache.org/jira/browse/CASSANDRA-18139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17678787#comment-17678787 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-18139 at 1/19/23 5:47 PM:
--------------------------------------------------------------------------

Looking into the usages of this method - it is used in new and old commands, features.

I think in new usages for 4.1 we should leave the change KB -> KiB etc

I am thinking the safest way is to revert the changes made to stringifyFileSize and create a new stringifyFileSizeBinaryUnits method to be used with flags and any new features - exceptions and trace logs for Guardrails for example. I will try to find time to create a patch later today or tomorrow. 


was (Author: e.dimitrova):
Looking into the usages of this method - it is used in new and old commands, features.

I think in new usages for 4.1 we should leave the change KB -> KiB etc

I am thinking the safest way is to revert the changes made to stringifyFileSize and create a new stringifyFileSizeBinaryUnits method to be used with any new features - exceptions and trace logs for Guardrails for example. I will try to find time to create a patch later today or tomorrow. 

> Revert changes to units output in FileUtils#stringifyFileSize post CASSANDRA-15234
> ----------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-18139
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-18139
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Local/Config
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.x
>
>
> As discussed in CASSANDRA-15234, FileUtils#stringifyFileSize is used in nodetool output which can break people parsing the nodetool output



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org