[GitHub] [skywalking-rover] wu-sheng commented on a diff in pull request #76: chore: improve readablity

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on code in PR #76:
URL: https://github.com/apache/skywalking-rover/pull/76#discussion_r1096390807


##########
bpf/profiling/network/args.h:
##########
@@ -244,9 +244,11 @@ static __inline struct socket_buffer_reader_t* read_socket_data(struct sock_data
     if (size > MAX_PROTOCOL_SOCKET_READ_LENGTH) {
         size = MAX_PROTOCOL_SOCKET_READ_LENGTH;
     }
+    // use & to work around an issue in kernel verifier.
+    // See https://github.com/apache/skywalking/discussions/10273

Review Comment:
   Please put a summary in the comments directly.
   We don't recommend to put a link in codes. The issue could be edited or be updated later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org