You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (Created) (JIRA)" <ji...@apache.org> on 2012/02/28 13:35:48 UTC
[jira] [Created] (CASSANDRA-3972) HintedHandoff fails to deliver
any hints
HintedHandoff fails to deliver any hints
----------------------------------------
Key: CASSANDRA-3972
URL: https://issues.apache.org/jira/browse/CASSANDRA-3972
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 1.1.0
Reporter: Brandon Williams
Assignee: Brandon Williams
Priority: Blocker
Fix For: 1.1.0
Summary says it all. Whether in a memtable or sstable, no hints are delivered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3972) HintedHandoff fails to deliver
any hints
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218143#comment-13218143 ]
Brandon Williams commented on CASSANDRA-3972:
---------------------------------------------
At least one problem here is that CFS.removeDeleted is removing everything here (though listing the hints family in the cli works correctly):
{code}
ColumnFamily hintsPage = ColumnFamilyStore.removeDeleted(hintStore.getColumnFamily(filter), Integer.MAX_VALUE);
{code}
At DEBUG you can see the columns collected, but then hintsPage is null. If we simply change this to:
{code}
ColumnFamily hintsPage = hintStore.getColumnFamily(filter);
{code}
Then at least some of the hints get sent.
> HintedHandoff fails to deliver any hints
> ----------------------------------------
>
> Key: CASSANDRA-3972
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3972
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Blocker
> Labels: hintedhandoff
> Fix For: 1.1.0
>
>
> Summary says it all. Whether in a memtable or sstable, no hints are delivered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3972) HintedHandoff fails to deliver
any hints
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218289#comment-13218289 ]
Sylvain Lebresne commented on CASSANDRA-3972:
---------------------------------------------
CASSANDRA-3716 made it so that purge don't use the current time internally and is only based on the column local deletion time and the value of gcBefore. So indeed, ColumnFamilyStore.removeDeleted(c, Integer.MAX_VALUE) will remove every expiring column since it basically means 'remove everything that will be expired at the end of time'. The current time should be used instead as gcBefore. Not sure what is the remaining problem though if it doesn't fix it fully.
> HintedHandoff fails to deliver any hints
> ----------------------------------------
>
> Key: CASSANDRA-3972
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3972
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Blocker
> Labels: hintedhandoff
> Fix For: 1.1.0
>
>
> Summary says it all. Whether in a memtable or sstable, no hints are delivered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3972) HintedHandoff fails to deliver
any hints
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218328#comment-13218328 ]
Jonathan Ellis commented on CASSANDRA-3972:
-------------------------------------------
+1
> HintedHandoff fails to deliver any hints
> ----------------------------------------
>
> Key: CASSANDRA-3972
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3972
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Blocker
> Labels: hintedhandoff
> Fix For: 1.1.0
>
> Attachments: 3972.txt
>
>
> Summary says it all. Whether in a memtable or sstable, no hints are delivered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-3972) HintedHandoff fails to deliver
any hints
Posted by "Brandon Williams (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams resolved CASSANDRA-3972.
-----------------------------------------
Resolution: Fixed
Reviewer: jbellis (was: slebresne)
Committed.
> HintedHandoff fails to deliver any hints
> ----------------------------------------
>
> Key: CASSANDRA-3972
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3972
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Blocker
> Labels: hintedhandoff
> Fix For: 1.1.0
>
> Attachments: 3972.txt
>
>
> Summary says it all. Whether in a memtable or sstable, no hints are delivered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3972) HintedHandoff fails to deliver
any hints
Posted by "Brandon Williams (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-3972:
----------------------------------------
Reviewer: slebresne
> HintedHandoff fails to deliver any hints
> ----------------------------------------
>
> Key: CASSANDRA-3972
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3972
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Blocker
> Labels: hintedhandoff
> Fix For: 1.1.0
>
> Attachments: 3972.txt
>
>
> Summary says it all. Whether in a memtable or sstable, no hints are delivered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3972) HintedHandoff fails to deliver
any hints
Posted by "Brandon Williams (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-3972:
----------------------------------------
Attachment: 3972.txt
That does indeed fix it. Patch to use the current time when filtering tombstones.
> HintedHandoff fails to deliver any hints
> ----------------------------------------
>
> Key: CASSANDRA-3972
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3972
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Blocker
> Labels: hintedhandoff
> Fix For: 1.1.0
>
> Attachments: 3972.txt
>
>
> Summary says it all. Whether in a memtable or sstable, no hints are delivered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3972) HintedHandoff fails to deliver
any hints
Posted by "Brandon Williams (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218248#comment-13218248 ]
Brandon Williams commented on CASSANDRA-3972:
---------------------------------------------
It's not too surprising then that a very long and arduous bisect points toward CASSANDRA-3716.
> HintedHandoff fails to deliver any hints
> ----------------------------------------
>
> Key: CASSANDRA-3972
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3972
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Blocker
> Labels: hintedhandoff
> Fix For: 1.1.0
>
>
> Summary says it all. Whether in a memtable or sstable, no hints are delivered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3972) HintedHandoff fails to deliver
any hints
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218227#comment-13218227 ]
Jonathan Ellis commented on CASSANDRA-3972:
-------------------------------------------
removeDeleted should just drop tombstones.
> HintedHandoff fails to deliver any hints
> ----------------------------------------
>
> Key: CASSANDRA-3972
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3972
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Brandon Williams
> Assignee: Brandon Williams
> Priority: Blocker
> Labels: hintedhandoff
> Fix For: 1.1.0
>
>
> Summary says it all. Whether in a memtable or sstable, no hints are delivered.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira