You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@logging.apache.org by sd...@apache.org on 2010/03/24 06:54:10 UTC
svn commit: r926941 -
/logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java
Author: sdeboy
Date: Wed Mar 24 05:54:09 2010
New Revision: 926941
URL: http://svn.apache.org/viewvc?rev=926941&view=rev
Log:
Changing column selection preference UI to only require single-clicking on the row to toggle the column pref on or off
Modified:
logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java
Modified: logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java
URL: http://svn.apache.org/viewvc/logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java?rev=926941&r1=926940&r2=926941&view=diff
==============================================================================
--- logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java (original)
+++ logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java Wed Mar 24 05:54:09 2010
@@ -205,7 +205,7 @@ public class LogPanelPreferencePanel ext
public void mouseClicked(MouseEvent e)
{
if (
- (e.getClickCount() > 1)
+ (e.getClickCount() == 1)
&& ((e.getModifiers() & InputEvent.BUTTON1_MASK) > 0))
{
int i = columnList.locationToIndex(e.getPoint());
RE: svn commit: r926941 - /logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java
Posted by Nathan Dye <na...@fedex.com>.
I'm sure it's obvious to you, but why is it OK to change a greater-than test to an equal test? In most cases I would change that to a greater-than-or-equal. Is something inside the { } decrementing e.getClickCount() ?
In ignorance,
Nathan Dye
EIS, Marketing Technical Administration
FedEx Services
1.901.434.5778 TEL
-----Original Message-----
From: sdeboy@apache.org [mailto:sdeboy@apache.org]
Sent: Wednesday, March 24, 2010 12:54 AM
To: general@logging.apache.org
Subject: svn commit: r926941 - /logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java
Author: sdeboy
Date: Wed Mar 24 05:54:09 2010
New Revision: 926941
URL: http://svn.apache.org/viewvc?rev=926941&view=rev
Log:
Changing column selection preference UI to only require single-clicking on the row to toggle the column pref on or off
Modified:
logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java
Modified: logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java
URL: http://svn.apache.org/viewvc/logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java?rev=926941&r1=926940&r2=926941&view=diff
==============================================================================
--- logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java (original)
+++ logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw/LogPanelPreferencePanel.java Wed Mar 24 05:54:09 2010
@@ -205,7 +205,7 @@ public class LogPanelPreferencePanel ext
public void mouseClicked(MouseEvent e)
{
if (
- (e.getClickCount() > 1)
+ (e.getClickCount() == 1)
&& ((e.getModifiers() & InputEvent.BUTTON1_MASK) > 0))
{
int i = columnList.locationToIndex(e.getPoint());