You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/12 06:11:09 UTC
[GitHub] [flink] luoyuxia opened a new pull request, #20247: introduce operation execution plugin
luoyuxia opened a new pull request, #20247:
URL: https://github.com/apache/flink/pull/20247
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
## Brief change log
*(for example:)*
- *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
- *Deployments RPC transmits only the blob storage reference*
- *TaskManagers retrieve the TaskInfo from the blob cache*
## Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (100MB)*
- *Extended integration test for recovery after master (JobManager) failure*
- *Added test that validates that TaskInfo is transferred only once across recoveries*
- *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a diff in pull request #20247: [FLINK-28628][hive] Introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
wuchong commented on code in PR #20247:
URL: https://github.com/apache/flink/pull/20247#discussion_r928660329
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java:
##########
@@ -81,6 +90,15 @@ public interface TableEnvironmentInternal extends TableEnvironment {
* @param operation The operation to be executed.
* @return the content of the execution result.
*/
+ TableResultInternal executeOperation(Operation operation);
Review Comment:
This sounds we can encapsulate the logic in the internal implementation instead of exposing them on the interface. From the perspective of users, they shouldn't care about the difference between `executeInternal()` and `executeOperation()`. It's very easy to call the wrong method for the users who use the `TableEnvironmentInternl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #20247: [FLINK-28628][hive] Introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #20247:
URL: https://github.com/apache/flink/pull/20247#discussion_r928517671
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java:
##########
@@ -81,6 +90,15 @@ public interface TableEnvironmentInternal extends TableEnvironment {
* @param operation The operation to be executed.
* @return the content of the execution result.
*/
+ TableResultInternal executeOperation(Operation operation);
Review Comment:
We can just implement the delegation in `executeInternal`. The reason I add `executeOperation` is to make the whole logic clear, like first try to use external implementation , and then `executeInternal` which is Flink's implementation.
I'm fine to put the delegation in `executeInternal`.
The reason Why no `executeOperation(List<ModifyOperation> operations)` is I don't want to expose much to user and I think it's no nesscessary. Now, this method is mainly used by `StatementSetOperation`. And if extern dialect wants to custom the implementation for the operation containing multi-insert, extern dialect can return a new operation like `HiveStatementSetOperation` and then still delegate it to `executeOperation(Operation operation)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #20247: [FLINK-28628][hive] Introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
wuchong commented on PR #20247:
URL: https://github.com/apache/flink/pull/20247#issuecomment-1193811700
Looks good to me. But please fix the compile problem.
PS: maybe you didn't configure the automatic code format in IDE. See https://nightlies.apache.org/flink/flink-docs-master/docs/flinkdev/ide_setup/#code-formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #20247: [FLINK-28628][hive] Introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #20247:
URL: https://github.com/apache/flink/pull/20247#discussion_r928517671
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java:
##########
@@ -81,6 +90,15 @@ public interface TableEnvironmentInternal extends TableEnvironment {
* @param operation The operation to be executed.
* @return the content of the execution result.
*/
+ TableResultInternal executeOperation(Operation operation);
Review Comment:
We can just implement the delegation in `executeInternal`. The reason I add `executeOperation` is to make the whole logic clear, like first try to use external implementation , and then `executeInternal` which is Flink's implementation.
I'm fine to put the delegation in `executeInternal`, which won't introduce new method for this interface.
The reason Why no `executeOperation(List<ModifyOperation> operations)` is I don't want to expose much to user and I think it's no nesscessary. Now, this method is mainly used by `StatementSetOperation`. And if extern dialect wants to custom the implementation for the operation containing multi-insert, extern dialect can return a new operation like `HiveStatementSetOperation` and then still delegate it to `executeOperation(Operation operation)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20247: introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20247:
URL: https://github.com/apache/flink/pull/20247#issuecomment-1181361644
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b91d6b86f094c1d0e4debdaafbd74e1df056d3d8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b91d6b86f094c1d0e4debdaafbd74e1df056d3d8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b91d6b86f094c1d0e4debdaafbd74e1df056d3d8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a diff in pull request #20247: [FLINK-28628][hive] Introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
wuchong commented on code in PR #20247:
URL: https://github.com/apache/flink/pull/20247#discussion_r928462089
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/delegation/DialectFactory.java:
##########
@@ -20,37 +20,52 @@
import org.apache.flink.annotation.Internal;
import org.apache.flink.table.api.config.TableConfigOptions;
+import org.apache.flink.table.api.internal.TableResultInternal;
import org.apache.flink.table.catalog.CatalogManager;
+import org.apache.flink.table.delegation.Executor;
+import org.apache.flink.table.delegation.OperationExternalExecutor;
import org.apache.flink.table.delegation.Parser;
import org.apache.flink.table.factories.Factory;
+import org.apache.flink.table.operations.Operation;
+
+import java.util.Optional;
/**
- * Factory that creates {@link Parser}.
+ * Factory that creates {@link Parser} and {@link OperationExternalExecutor}.
*
* <p>The {@link #factoryIdentifier()} is identified by matching it against {@link
* TableConfigOptions#TABLE_SQL_DIALECT}.
*/
@Internal
-public interface ParserFactory extends Factory {
+public interface DialectFactory extends Factory {
/** Creates a new parser. */
Parser create(Context context);
+ default OperationExternalExecutor createOperatorExternalExecutor(Context context) {
Review Comment:
`External` might be misleading here, what about `ExtendedOperationExecutor`?
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java:
##########
@@ -81,6 +90,15 @@ public interface TableEnvironmentInternal extends TableEnvironment {
* @param operation The operation to be executed.
* @return the content of the execution result.
*/
+ TableResultInternal executeOperation(Operation operation);
Review Comment:
This method is quite confusing that what's the difference between this one and `executeInternal`. Besides, why there are no `executeOperation(List<ModifyOperation> operations)` ?
Couldn't we just implement the delegation in `executeInternal`?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/delegation/DialectFactory.java:
##########
@@ -62,5 +77,20 @@ public CatalogManager getCatalogManager() {
public PlannerContext getPlannerContext() {
return plannerContext;
}
+
+ @Override
+ public Executor getExecutor() {
+ return executor;
+ }
+ }
+
+ /** Default implementation for {@link OperationExternalExecutor}. */
+ class DefaultOperationExternalExecutor implements OperationExternalExecutor {
Review Comment:
The default implementation can be `EmptyOperationExecutor` with comment: a default implementation of `ExtendedOperationExecutor` that doesn't extend any operation behavior but forward all operations to the Flink planner.
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java:
##########
@@ -53,6 +54,14 @@ public interface TableEnvironmentInternal extends TableEnvironment {
*/
Parser getParser();
+ /**
+ * Return a {@link OperationExternalExecutor} that provides method for executing operation in
+ * external implementation.
+ *
+ * @return initialized {@link OperationExternalExecutor}.
+ */
+ OperationExternalExecutor getOperationExternalExecutor();
Review Comment:
It seems this method is only called by the implementation itself. So no need to expose it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #20247: [FLINK-28628][hive] Introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #20247:
URL: https://github.com/apache/flink/pull/20247#issuecomment-1194861729
@wuchong The CI is passed now. Could you please help merge so that I can move on the other issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on pull request #20247: introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on PR #20247:
URL: https://github.com/apache/flink/pull/20247#issuecomment-1182702339
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] luoyuxia commented on a diff in pull request #20247: [FLINK-28628][hive] Introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
luoyuxia commented on code in PR #20247:
URL: https://github.com/apache/flink/pull/20247#discussion_r928517671
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentInternal.java:
##########
@@ -81,6 +90,15 @@ public interface TableEnvironmentInternal extends TableEnvironment {
* @param operation The operation to be executed.
* @return the content of the execution result.
*/
+ TableResultInternal executeOperation(Operation operation);
Review Comment:
We can just implement the delegation in `executeInternal`. The reason I add `executeOperation` is to make the whole logic clear, like first try to use external implementation , and then `executeInternal` which is Flink's implementation.
I'm fine to put the delegation in `executeInternal`.
The reason Why no `executeOperation(List<ModifyOperation> operations)` is I don't want to expose much to user and I think it's no nesscessary. Now, this method is mainly used by `StatementSetOperation`. And if extern dialect wants to custom the implementation for the operation containing multi-insert, extern dialect can return a new operation like `HiveStatementSetOperation` and then still delegate it to `executeOperation(Operation operation)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #20247: [FLINK-28628][hive] Introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
wuchong commented on PR #20247:
URL: https://github.com/apache/flink/pull/20247#issuecomment-1193944938
`TableEnvironmentTest.testManagedTable` are failed. Please **append** commits to fix the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #20247: [FLINK-28628][hive] Introduce operation execution plugin
Posted by GitBox <gi...@apache.org>.
wuchong merged PR #20247:
URL: https://github.com/apache/flink/pull/20247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org