You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Nino Martinez (JIRA)" <ji...@apache.org> on 2008/02/29 10:02:51 UTC

[jira] Created: (WICKET-1382) Image could be made ajax aware..

Image could be made ajax aware..
--------------------------------

                 Key: WICKET-1382
                 URL: https://issues.apache.org/jira/browse/WICKET-1382
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
            Reporter: Nino Martinez
            Priority: Minor


It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.

Pasted from mailinglist:

most people want stable urls for their images i would imagine, so they
can be cached by the browser.

...."
in case of ajax this doesnt work because the url has to change so that
browser needs to know to refresh it.

maybe image can know if its requested within an ajax request and
automatically add random noise to the url...there maybe room for
improvement here.
"......


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1382) Image could be made ajax aware..

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930245#action_12930245 ] 

Hudson commented on WICKET-1382:
--------------------------------

Integrated in Apache Wicket 1.5.x #497 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/497/])
    WICKET-1382 Image could be made ajax aware

Add 'anti cache' parameter to Image components when rerendering in Ajax requests.


> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.5-M4
>
>         Attachments: WICKET-1382.patch
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1382) Image could be made ajax aware..

Posted by "Jeremy Thomerson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeremy Thomerson updated WICKET-1382:
-------------------------------------

    Fix Version/s:     (was: 1.5-M3)
                   1.5-M4

> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.5-M4
>
>         Attachments: WICKET-1382.patch
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1382) Image could be made ajax aware..

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924354#action_12924354 ] 

Igor Vaynberg commented on WICKET-1382:
---------------------------------------

yeah, he is talking about target.add(imagecomponent)

in order to get images to get repainted in ajax one has to use NonCachingImage so the ajax update also causes the url to be updated, otherwise browser wont touch it.

i dont think it would be hard, in image.oncomponenttag() we can check if its inside the ajax request and add the random nibble to the url

> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.5-M3
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1382) Image could be made ajax aware..

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-1382:
----------------------------------

    Fix Version/s: 1.5-M1

> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.5-M1
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-1382) Image could be made ajax aware..

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reassigned WICKET-1382:
---------------------------------------

    Assignee: Martin Grigorov

> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.5-M3
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1382) Image could be made ajax aware..

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-1382:
----------------------------------

    Fix Version/s: 1.5-M3
                       (was: 1.5-M2)

> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.5-M3
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1382) Image could be made ajax aware..

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12924340#action_12924340 ] 

Martin Grigorov commented on WICKET-1382:
-----------------------------------------

By "add an image" do you really mean "update an image" ?
Can you provide a quickstart to show what you described above ?

> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.5-M3
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1382) Image could be made ajax aware..

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-1382.
-------------------------------------

    Resolution: Fixed

Improved with r1033158

> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.5-M4
>
>         Attachments: WICKET-1382.patch
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1382) Image could be made ajax aware..

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg updated WICKET-1382:
----------------------------------

    Fix Version/s: 1.5-M2
                       (was: 1.5-M1)

> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Priority: Minor
>             Fix For: 1.5-M2
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1382) Image could be made ajax aware..

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929836#action_12929836 ] 

Igor Vaynberg commented on WICKET-1382:
---------------------------------------

looks good, lets apply

> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.5-M4
>
>         Attachments: WICKET-1382.patch
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1382) Image could be made ajax aware..

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-1382:
------------------------------------

    Attachment: WICKET-1382.patch

Please review the patch and tests.

> Image could be made ajax aware..
> --------------------------------
>
>                 Key: WICKET-1382
>                 URL: https://issues.apache.org/jira/browse/WICKET-1382
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>            Reporter: Nino Martinez
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.5-M3
>
>         Attachments: WICKET-1382.patch
>
>
> It could be very cool if Image could be made ajax aware(so that it would add the random noise if it's added in ajax context).. Currently if you add a new image via ajax it's not updated(because the browser doesnt know it has to reload it). Normal procedure are to use noncaching image instead, but its confusing a lot of people.
> Pasted from mailinglist:
> most people want stable urls for their images i would imagine, so they
> can be cached by the browser.
> ...."
> in case of ajax this doesnt work because the url has to change so that
> browser needs to know to refresh it.
> maybe image can know if its requested within an ajax request and
> automatically add random noise to the url...there maybe room for
> improvement here.
> "......

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.