[GitHub] [airflow] dstandish commented on issue #6426: [AIRFLOW-5751] add get_uri method to Connection

[GitBox <gi...@apache.org>]

dstandish commented on issue #6426: [AIRFLOW-5751] add get_uri method to Connection
URL: https://github.com/apache/airflow/pull/6426#issuecomment-546806770
 
 
   Interesting.  Yeah I think it's good for hooks to have this.  I'd like it if every hook had a static method that took all valid params and produce correct URI.  With a `conn.get_uri()` method, this would be more convenient -- hook get_uri methods could just create the conn object and call get_uri.
   
   Stepping back, do you think this method is good to add?  
   
   I think it's good to have a standardized method of generating a uri that is guaranteed to parse correctly.
   
   So a user could build their function with arguments to conn, and then generate URI that will work.  No fussing with urllib.  No digging through to see how things are parsed.
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services