You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/02 18:02:57 UTC
[GitHub] [pulsar-helm-chart] ThelonKarrde opened a new pull request, #284: Add nodeSelector to cluster initialize pod
ThelonKarrde opened a new pull request, #284:
URL: https://github.com/apache/pulsar-helm-chart/pull/284
Fixes #<xyz>
### Motivation
Add an option to choose where to run pulsar-cluster-initialize pod. Sometimes there is a necessity to run only on certain nodes.
### Modifications
Added nodeSelector option to the pulsar-cluster-initialize job.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] ThelonKarrde commented on pull request #284: Add nodeSelector to cluster initialize pod
Posted by GitBox <gi...@apache.org>.
ThelonKarrde commented on PR #284:
URL: https://github.com/apache/pulsar-helm-chart/pull/284#issuecomment-1252718787
@michaeljmarshall indeed I pushed the wrong changes. Thank you for the fix. It works locally.
Also pushed a fix for typo in values description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall merged pull request #284: Add nodeSelector to cluster initialize pod
Posted by GitBox <gi...@apache.org>.
michaeljmarshall merged PR #284:
URL: https://github.com/apache/pulsar-helm-chart/pull/284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a diff in pull request #284: Add nodeSelector to cluster initialize pod
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on code in PR #284:
URL: https://github.com/apache/pulsar-helm-chart/pull/284#discussion_r973653797
##########
charts/pulsar/templates/pulsar-cluster-initialize.yaml:
##########
@@ -114,5 +114,9 @@ spec:
volumes:
{{- include "pulsar.toolset.certs.volumes" . | nindent 6 }}
restartPolicy: OnFailure
+ {{- if .Values.pulsar_metadata.nodeSelector }}
+ nodeSelector:
+{{ toYaml .Values.pulsar_metadata.nodeSelector | indent 6 }}
Review Comment:
I am pretty sure this needs to be indented 8, not 6. Were you able to verify this change works?
```suggestion
{{ toYaml .Values.pulsar_metadata.nodeSelector | indent 8 }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] ThelonKarrde commented on pull request #284: Add nodeSelector to cluster initialize pod
Posted by GitBox <gi...@apache.org>.
ThelonKarrde commented on PR #284:
URL: https://github.com/apache/pulsar-helm-chart/pull/284#issuecomment-1208372338
@MarvinCai @michaeljmarshall pinging here since you potentially might be the right persons to review it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] ThelonKarrde commented on pull request #284: Add nodeSelector to cluster initialize pod
Posted by GitBox <gi...@apache.org>.
ThelonKarrde commented on PR #284:
URL: https://github.com/apache/pulsar-helm-chart/pull/284#issuecomment-1248561460
@MarvinCai @michaeljmarshall ping here again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org