You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/10/17 09:07:54 UTC
[GitHub] [maven] cstamas opened a new pull request, #831: Session close in Maven
cstamas opened a new pull request, #831:
URL: https://github.com/apache/maven/pull/831
Session close in Maven
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #831: [3.9.x][MNG-7586] Update Maven Resolver to 1.9.0
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #831:
URL: https://github.com/apache/maven/pull/831#issuecomment-1312444744
Shouldn't this be skipped for 1.9.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #831: [3.9.x] Maven changes for upcoming resolver 1.9
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #831:
URL: https://github.com/apache/maven/pull/831#discussion_r1008743550
##########
maven-core/src/main/java/org/apache/maven/internal/aether/ResolverLifecycle.java:
##########
@@ -0,0 +1,54 @@
+package org.apache.maven.internal.aether;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.annotation.PreDestroy;
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Provider;
+
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.sisu.EagerSingleton;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Maven internal component that bridges container "shut down" to {@link RepositorySystem#shutdown()}.
+ *
+ * @since 3.9.0
+ */
+@Named
+@EagerSingleton
+public final class ResolverLifecycle
+{
+ private final Provider<RepositorySystem> repositorySystemProvider;
+
+ @Inject
+ public ResolverLifecycle( Provider<RepositorySystem> repositorySystemProvider )
+ {
+ this.repositorySystemProvider = requireNonNull( repositorySystemProvider );
+ }
+
+ @PreDestroy
Review Comment:
Now this is back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #831: [3.9.x][MNG-7586] Update Maven Resolver to 1.9.1
Posted by GitBox <gi...@apache.org>.
cstamas commented on PR #831:
URL: https://github.com/apache/maven/pull/831#issuecomment-1318311353
recycled rather :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #831: [3.9.x][MNG-7586] Update Maven Resolver to 1.9.1
Posted by GitBox <gi...@apache.org>.
cstamas merged PR #831:
URL: https://github.com/apache/maven/pull/831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #831: [3.9.x] Maven changes for upcoming resolver 1.9
Posted by GitBox <gi...@apache.org>.
cstamas commented on code in PR #831:
URL: https://github.com/apache/maven/pull/831#discussion_r1008745807
##########
maven-core/src/main/java/org/apache/maven/internal/aether/ResolverLifecycle.java:
##########
@@ -0,0 +1,54 @@
+package org.apache.maven.internal.aether;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.annotation.PreDestroy;
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Provider;
+
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.sisu.EagerSingleton;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Maven internal component that bridges container "shut down" to {@link RepositorySystem#shutdown()}.
+ *
+ * @since 3.9.0
+ */
+@Named
+@EagerSingleton
+public final class ResolverLifecycle
+{
+ private final Provider<RepositorySystem> repositorySystemProvider;
+
+ @Inject
+ public ResolverLifecycle( Provider<RepositorySystem> repositorySystemProvider )
+ {
+ this.repositorySystemProvider = requireNonNull( repositorySystemProvider );
+ }
+
+ @PreDestroy
Review Comment:
Yes, we never removed it from Maven, but we did from Resolver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #831: [3.9.x] Maven changes for upcoming resolver 1.9
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #831:
URL: https://github.com/apache/maven/pull/831#discussion_r1008746028
##########
maven-core/src/main/java/org/apache/maven/internal/aether/ResolverLifecycle.java:
##########
@@ -0,0 +1,54 @@
+package org.apache.maven.internal.aether;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.annotation.PreDestroy;
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Provider;
+
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.sisu.EagerSingleton;
+
+import static java.util.Objects.requireNonNull;
+
+/**
+ * Maven internal component that bridges container "shut down" to {@link RepositorySystem#shutdown()}.
+ *
+ * @since 3.9.0
+ */
+@Named
+@EagerSingleton
+public final class ResolverLifecycle
+{
+ private final Provider<RepositorySystem> repositorySystemProvider;
+
+ @Inject
+ public ResolverLifecycle( Provider<RepositorySystem> repositorySystemProvider )
+ {
+ this.repositorySystemProvider = requireNonNull( repositorySystemProvider );
+ }
+
+ @PreDestroy
Review Comment:
Ah, ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org