You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/12/22 04:41:58 UTC
[GitHub] [geode] pivotal-jbarrett opened a new pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
pivotal-jbarrett opened a new pull request #7221:
URL: https://github.com/apache/geode/pull/7221
Happy Holidays!
The only gutter that should be so colorful is the one on your home for the holidays and not the warnings gutter in IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1006909742
This pull request **introduces 2 alerts** when merging 3549ae9d83970df35a8552fdbcd73ff94b23d71b into eb6a0dca57cb411eb6cb7ac31906f1e7d111b3b9 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-7f11c4df79fb31a9d3a838117abb34b57fa1e5f6)
**new alerts:**
* 1 for Dereferenced variable may be null
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1010283330
> While it's not actually gating new PRs right now due to some implementation issues, there was a vote that passed to make the LGTM pre-checkin job a gating step, so in the spirit of that, could the two remaining alerts either be fixed or suppressed as false positives (with explanatory comments) please?
Both of those have been suppressed, following their Java suppression guide, and tickets for the false-positive issues have been opened. Unfortunately it looks like their Java suppression technique is also broken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1015797494
> Looks like merging of #7217 caused the two conflicts:
>
> * geode-core/src/main/java/org/apache/geode/management/internal/JmxRmiOpenTypesSerialFilter.java was deleted
> * geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java is now using classes that moved from geode-core to geode-serialization (and may have been renamed)
Yeah, this PR gets merge conflicts daily since it touches everything. I will rebase later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1010194813
While it's not actually gating new PRs right now due to some implementation issues, there was a vote that passed to make the LGTM pre-checkin job a gating step, so in the spirit of that, could the two remaining alerts either be fixed or suppressed as false positives (with explanatory comments) please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1013528776
> I'm trying to add my approval, but github prevents me from getting to the review dialog with:
>
> ```
> Oh My
> Sorry, this file list is taking too long to generate.
> ```
>
> And it never finishes loading or presenting the dialog for submitting the review.
>
> Is there a way to submit a review/approval without going through the standard gui that hits the above?
@kirklund One potential workaround would be to use the github CLI: https://cli.github.com/manual/gh_pr_review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-999294226
This pull request **introduces 5 alerts** when merging 5150e9abd527002235aecf024297e7c555b542c8 into ebf8479fffb5775b1f45801aa9382c2dad7106e0 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-e332eade096e951f3ec124cece9bcd8fb0b72004)
**new alerts:**
* 2 for Boxed variable is never null
* 1 for Dereferenced variable may be null
* 1 for Missing format argument
* 1 for Useless null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1007560729
This pull request **introduces 2 alerts** when merging 9e3d90b18d89a0bad1e7e3777b46cfedc58ca82a into eb6a0dca57cb411eb6cb7ac31906f1e7d111b3b9 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-367010e51d57a04167d258cca1d22005829db053)
**new alerts:**
* 1 for Dereferenced variable may be null
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1015793363
Looks like merging of #7217 caused the two conflicts:
* geode-core/src/main/java/org/apache/geode/management/internal/JmxRmiOpenTypesSerialFilter.java was deleted
* geode-core/src/main/java/org/apache/geode/management/internal/ManagementAgent.java is now using classes that moved from geode-core to geode-serialization (and may have been renamed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1009401240
This pull request **introduces 2 alerts** when merging ae11b9382708ff5c0e17dba76468a4452acdc66b into 79c606ff8bf49dcdbea343ace050a9eb74bffa1d - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-eb8e13bfb76692cf8f372d40e281a9106220862c)
**new alerts:**
* 1 for Dereferenced variable may be null
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-999937407
This pull request **introduces 4 alerts** when merging d096f34887296e9e37dd21b2a3045834a562c344 into ebf8479fffb5775b1f45801aa9382c2dad7106e0 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-d2f063a4e6826a7fb0ccc6ffd137c419eb620422)
**new alerts:**
* 2 for Missing space in string literal
* 1 for Dereferenced variable may be null
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund edited a comment on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
kirklund edited a comment on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1013523043
I'm trying to add my approval, but github prevents me from getting to the review dialog with:
```
Oh My
Sorry, this file list is taking too long to generate.
```
And it never finishes loading or presenting the dialog for submitting the review.
Is there a way to submit a review/approval without going through the standard gui that hits the above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1014722121
@kirklund and others, I wouldn't focus too deep into each file. The changes are automated IntelliJ cleanups across the entire codebase. Think of it along the same lines as a mass "reformat" change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] pivotal-jbarrett merged pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
pivotal-jbarrett merged pull request #7221:
URL: https://github.com/apache/geode/pull/7221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-999969559
This pull request **introduces 2 alerts** when merging 679ae3bb366c7916a7f93b1fa87aaffd6a323609 into ebf8479fffb5775b1f45801aa9382c2dad7106e0 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-8ec9b323ecb4f8697b1dfbcba72574bcfaca28be)
**new alerts:**
* 1 for Dereferenced variable may be null
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1007035687
This pull request **introduces 2 alerts** when merging 1d03c59df85b18ce7c0f305f7a1ad135a3ebe092 into eb6a0dca57cb411eb6cb7ac31906f1e7d111b3b9 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-26a2f56fd3560c0bcee146e3d4f27144837c0611)
**new alerts:**
* 1 for Dereferenced variable may be null
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1007560729
This pull request **introduces 2 alerts** when merging 9e3d90b18d89a0bad1e7e3777b46cfedc58ca82a into eb6a0dca57cb411eb6cb7ac31906f1e7d111b3b9 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-367010e51d57a04167d258cca1d22005829db053)
**new alerts:**
* 1 for Dereferenced variable may be null
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1010346814
This pull request **introduces 1 alert** when merging 6bd619688ecf0b2f3a7c773fe71e715088791b9d into 233533bde74aaf35ca6c0ac502f2214fb61f1d33 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-6acc38a79cd6e781f29cd3f89838be99d068458f)
**new alerts:**
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1011770841
This pull request **introduces 1 alert** when merging 24b73f20a37aaac6047a9ccb87106fafff8d81d7 into ac04dc4348c9231960b46cefca13da41c1bff97e - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-1b70aa444a17dff12eaad0c73eb063b619c71f4b)
**new alerts:**
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1015852301
This pull request **introduces 1 alert** when merging fbcf15b09142c7b29f8a6e066e3ab6043d9b9a4e into 7978abf34707d11da45cff0b7cb7445f18d21438 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-4fba4f7fe3d50903f6c14afd87edc07de7f49a94)
**new alerts:**
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] kirklund commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
kirklund commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1013523043
I'm trying to add my approval, but github prevents me from getting to review dialog with:
```
Oh My
Sorry, this file list is taking too long to generate.
```
And it never finishes loading or presenting the dialog for submitting the review.
Is there a way to submit a review/approval without going through the standard gui that hits the above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1000508618
This pull request **introduces 2 alerts** when merging 1e615c2238e3e51663b046fce98371b63dcb3375 into ebf8479fffb5775b1f45801aa9382c2dad7106e0 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-33c2a1e71249b987f857248f724d4d7ff90beb0b)
**new alerts:**
* 1 for Dereferenced variable may be null
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] lgtm-com[bot] commented on pull request #7221: GEODE-6588: Mass cleanup of static analyzer warnings.
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #7221:
URL: https://github.com/apache/geode/pull/7221#issuecomment-1008441855
This pull request **introduces 2 alerts** when merging 08cdacae222b08052f7f5de17305e04533220606 into 87c32e4b85d5b5150a5290ab1e7f1919020e4bf9 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-2240b9cd954f9dd5a8df5b7cbd1d9f447e8c5962)
**new alerts:**
* 1 for Dereferenced variable may be null
* 1 for Boxed variable is never null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org