You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2013/09/23 14:30:53 UTC
ClientProperties.setQuirkXyz
Hi,
Can we safely remove all IE related properties in ClientProperties in
Wicket 7?
For
example org.apache.wicket.protocol.http.request.WebClientInfo#setInternetExplorerProperties
does:
properties.setProprietaryIECssExpressionsSupported(true);
properties.setQuirkCssPositioningOneSideOnly(true);
properties.setQuirkIERepaint(true);
properties.setQuirkIESelectZIndex(true);
properties.setQuirkIETextareaNewlineObliteration(true);
properties.setQuirkIESelectPercentWidth(true);
properties.setQuirkIESelectListDomUpdate(true);
properties.setQuirkIETablePercentWidthScrollbarError(true);
properties.setQuirkCssBackgroundAttachmentUseFixed(true);
properties.setQuirkCssBorderCollapseInside(true);
properties.setQuirkCssBorderCollapseFor0Padding(true);
if (properties.getBrowserVersionMajor() < 7)
{
properties.setProprietaryIEPngAlphaFilterRequired(true);
}
I have never needed to use these properties in my applications.
And I don't remember anyone asking about them in the mailing lists, or a
ticket about them in Jira.
Are they really needed or they can be removed ?
Re: ClientProperties.setQuirkXyz
Posted by Martin Dilger <ma...@gmail.com>.
we have a fair amount of wicket applications which support all major
browsers, none uses these properties.
Sent from my mobile
Am 23.09.2013 17:56 schrieb "Martin Grigorov" <mg...@apache.org>:
> I have to look closer to all properties but I guess my answer will be YES.
> The properties I pasted in my first mail are obsolete for newer versions of
> IE.
> If we want to support them then we have to find in which versions of which
> browsers they are still valid.
> Many of the properties have this in their javadoc:
> This quirk occurs with:
> * <ul>
> * <li>Internet Explorer 6 (Windows)</li>
> * </ul>
>
> IE6 is not supported by Wicket since a while. Even IE7 is not supported
> since Wicket 6.
>
> I think Modernizr should be used for such checks.
> I believe Wicket users do not use these properties because otherwise I'd
> expect bug reports that their values are not correct for newer versions of
> IE.
>
>
>
> On Mon, Sep 23, 2013 at 3:33 PM, Sven Meier <sv...@meiers.net> wrote:
>
> > I've never used these.
> >
> > But we have Mozilla related 'quirks' properties too, do you propose to
> > remove them too?
> >
> > Sven
> >
> >
> > On 09/23/2013 02:30 PM, Martin Grigorov wrote:
> >
> >> Hi,
> >>
> >> Can we safely remove all IE related properties in ClientProperties in
> >> Wicket 7?
> >>
> >> For
> >> example org.apache.wicket.protocol.**http.request.WebClientInfo#**
> >> setInternetExplorerProperties
> >> does:
> >>
> >> properties.**setProprietaryIECssExpressions**Supported(true);
> >> properties.**setQuirkCssPositioningOneSideO**nly(true);
> >> properties.setQuirkIERepaint(**true);
> >> properties.**setQuirkIESelectZIndex(true);
> >> properties.**setQuirkIETextareaNewlineOblit**eration(true);
> >> properties.**setQuirkIESelectPercentWidth(**true);
> >> properties.**setQuirkIESelectListDomUpdate(**true);
> >> properties.**setQuirkIETablePercentWidthScr**ollbarError(true);
> >> properties.**setQuirkCssBackgroundAttachmen**tUseFixed(true);
> >> properties.**setQuirkCssBorderCollapseInsid**e(true);
> >> properties.**setQuirkCssBorderCollapseFor0P**adding(true);
> >>
> >> if (properties.**getBrowserVersionMajor() < 7)
> >> {
> >> properties.**setProprietaryIEPngAlphaFilter**Required(true);
> >> }
> >>
> >> I have never needed to use these properties in my applications.
> >> And I don't remember anyone asking about them in the mailing lists, or a
> >> ticket about them in Jira.
> >>
> >> Are they really needed or they can be removed ?
> >>
> >>
> >
>
Re: ClientProperties.setQuirkXyz
Posted by Sven Meier <sv...@meiers.net>.
> I believe Wicket users do not use these properties because otherwise
I'd expect bug reports
> that their values are not correct for newer versions of IE.
Sounds reasonable.
Sven
On 09/23/2013 05:56 PM, Martin Grigorov wrote:
> I have to look closer to all properties but I guess my answer will be YES.
> The properties I pasted in my first mail are obsolete for newer versions of
> IE.
> If we want to support them then we have to find in which versions of which
> browsers they are still valid.
> Many of the properties have this in their javadoc:
> This quirk occurs with:
> * <ul>
> * <li>Internet Explorer 6 (Windows)</li>
> * </ul>
>
> IE6 is not supported by Wicket since a while. Even IE7 is not supported
> since Wicket 6.
>
> I think Modernizr should be used for such checks.
> I believe Wicket users do not use these properties because otherwise I'd
> expect bug reports that their values are not correct for newer versions of
> IE.
>
>
>
> On Mon, Sep 23, 2013 at 3:33 PM, Sven Meier <sv...@meiers.net> wrote:
>
>> I've never used these.
>>
>> But we have Mozilla related 'quirks' properties too, do you propose to
>> remove them too?
>>
>> Sven
>>
>>
>> On 09/23/2013 02:30 PM, Martin Grigorov wrote:
>>
>>> Hi,
>>>
>>> Can we safely remove all IE related properties in ClientProperties in
>>> Wicket 7?
>>>
>>> For
>>> example org.apache.wicket.protocol.**http.request.WebClientInfo#**
>>> setInternetExplorerProperties
>>> does:
>>>
>>> properties.**setProprietaryIECssExpressions**Supported(true);
>>> properties.**setQuirkCssPositioningOneSideO**nly(true);
>>> properties.setQuirkIERepaint(**true);
>>> properties.**setQuirkIESelectZIndex(true);
>>> properties.**setQuirkIETextareaNewlineOblit**eration(true);
>>> properties.**setQuirkIESelectPercentWidth(**true);
>>> properties.**setQuirkIESelectListDomUpdate(**true);
>>> properties.**setQuirkIETablePercentWidthScr**ollbarError(true);
>>> properties.**setQuirkCssBackgroundAttachmen**tUseFixed(true);
>>> properties.**setQuirkCssBorderCollapseInsid**e(true);
>>> properties.**setQuirkCssBorderCollapseFor0P**adding(true);
>>>
>>> if (properties.**getBrowserVersionMajor() < 7)
>>> {
>>> properties.**setProprietaryIEPngAlphaFilter**Required(true);
>>> }
>>>
>>> I have never needed to use these properties in my applications.
>>> And I don't remember anyone asking about them in the mailing lists, or a
>>> ticket about them in Jira.
>>>
>>> Are they really needed or they can be removed ?
>>>
>>>
Re: ClientProperties.setQuirkXyz
Posted by Martin Grigorov <mg...@apache.org>.
I have to look closer to all properties but I guess my answer will be YES.
The properties I pasted in my first mail are obsolete for newer versions of
IE.
If we want to support them then we have to find in which versions of which
browsers they are still valid.
Many of the properties have this in their javadoc:
This quirk occurs with:
* <ul>
* <li>Internet Explorer 6 (Windows)</li>
* </ul>
IE6 is not supported by Wicket since a while. Even IE7 is not supported
since Wicket 6.
I think Modernizr should be used for such checks.
I believe Wicket users do not use these properties because otherwise I'd
expect bug reports that their values are not correct for newer versions of
IE.
On Mon, Sep 23, 2013 at 3:33 PM, Sven Meier <sv...@meiers.net> wrote:
> I've never used these.
>
> But we have Mozilla related 'quirks' properties too, do you propose to
> remove them too?
>
> Sven
>
>
> On 09/23/2013 02:30 PM, Martin Grigorov wrote:
>
>> Hi,
>>
>> Can we safely remove all IE related properties in ClientProperties in
>> Wicket 7?
>>
>> For
>> example org.apache.wicket.protocol.**http.request.WebClientInfo#**
>> setInternetExplorerProperties
>> does:
>>
>> properties.**setProprietaryIECssExpressions**Supported(true);
>> properties.**setQuirkCssPositioningOneSideO**nly(true);
>> properties.setQuirkIERepaint(**true);
>> properties.**setQuirkIESelectZIndex(true);
>> properties.**setQuirkIETextareaNewlineOblit**eration(true);
>> properties.**setQuirkIESelectPercentWidth(**true);
>> properties.**setQuirkIESelectListDomUpdate(**true);
>> properties.**setQuirkIETablePercentWidthScr**ollbarError(true);
>> properties.**setQuirkCssBackgroundAttachmen**tUseFixed(true);
>> properties.**setQuirkCssBorderCollapseInsid**e(true);
>> properties.**setQuirkCssBorderCollapseFor0P**adding(true);
>>
>> if (properties.**getBrowserVersionMajor() < 7)
>> {
>> properties.**setProprietaryIEPngAlphaFilter**Required(true);
>> }
>>
>> I have never needed to use these properties in my applications.
>> And I don't remember anyone asking about them in the mailing lists, or a
>> ticket about them in Jira.
>>
>> Are they really needed or they can be removed ?
>>
>>
>
Re: ClientProperties.setQuirkXyz
Posted by Sven Meier <sv...@meiers.net>.
I've never used these.
But we have Mozilla related 'quirks' properties too, do you propose to
remove them too?
Sven
On 09/23/2013 02:30 PM, Martin Grigorov wrote:
> Hi,
>
> Can we safely remove all IE related properties in ClientProperties in
> Wicket 7?
>
> For
> example org.apache.wicket.protocol.http.request.WebClientInfo#setInternetExplorerProperties
> does:
>
> properties.setProprietaryIECssExpressionsSupported(true);
> properties.setQuirkCssPositioningOneSideOnly(true);
> properties.setQuirkIERepaint(true);
> properties.setQuirkIESelectZIndex(true);
> properties.setQuirkIETextareaNewlineObliteration(true);
> properties.setQuirkIESelectPercentWidth(true);
> properties.setQuirkIESelectListDomUpdate(true);
> properties.setQuirkIETablePercentWidthScrollbarError(true);
> properties.setQuirkCssBackgroundAttachmentUseFixed(true);
> properties.setQuirkCssBorderCollapseInside(true);
> properties.setQuirkCssBorderCollapseFor0Padding(true);
>
> if (properties.getBrowserVersionMajor() < 7)
> {
> properties.setProprietaryIEPngAlphaFilterRequired(true);
> }
>
> I have never needed to use these properties in my applications.
> And I don't remember anyone asking about them in the mailing lists, or a
> ticket about them in Jira.
>
> Are they really needed or they can be removed ?
>