[GitHub] [airflow] uranusjr commented on a diff in pull request #23000: Do not validate Params with no default value during DAG parsing

[GitBox <gi...@apache.org>]

uranusjr commented on code in PR #23000:
URL: https://github.com/apache/airflow/pull/23000#discussion_r850183347


##########
airflow/models/param.py:
##########
@@ -62,7 +62,9 @@ def _warn_if_not_json(value):
                 DeprecationWarning,
             )
 
-    def resolve(self, value: Any = NOTSET, suppress_exception: bool = False) -> Any:
+    def resolve(
+        self, value: Any = NOTSET, suppress_exception: bool = False, is_dag_parsing: bool = False

Review Comment:
   Need to add this new argument to the docstring, and especially explain how it’s different from `suppress_exception`.
   
   On a relative note, is there are more functional-descriptive name to this flag? Instead of `is_dag_parsing` (which means “this is set when DAG is being parsed”), something that describes how the flag changes behaviour, like how `suppress_exception` means “exceptions will not be raised”.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org