You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Andras Salamon <an...@melda.info> on 2019/03/04 14:23:28 UTC
Review Request 70111: OOZIE-3335 Cleanup parseFilter methods
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70111/
-----------------------------------------------------------
Review request for oozie and Kinga Marton.
Repository: oozie-git
Description
-------
OOZIE-3335 Cleanup parseFilter methods
Diffs
-----
core/src/main/java/org/apache/oozie/BundleEngine.java 19b54e6a0
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 0aa56d1ef
core/src/main/java/org/apache/oozie/DagEngine.java 70ce96122
core/src/main/java/org/apache/oozie/FilterParser.java cd92a7c62
core/src/main/java/org/apache/oozie/FilterParserException.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java 587dbf9bb
core/src/main/java/org/apache/oozie/command/bundle/BulkBundleXCommand.java dbe70ae63
core/src/main/java/org/apache/oozie/command/bundle/BundleJobsXCommand.java 614e42290
core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java d3959019a
core/src/main/java/org/apache/oozie/command/coord/CoordJobsXCommand.java ba703f901
core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java ef3421d10
core/src/main/java/org/apache/oozie/command/wf/BulkWorkflowXCommand.java 0692a652d
core/src/main/java/org/apache/oozie/command/wf/JobsXCommand.java a82b03b57
core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 42961157a
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 6e1ea3e5b
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java 4c641d7e8
core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java 7797ff507
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java 45a893d20
core/src/main/java/org/apache/oozie/service/AuthorizationService.java 2c19aa29d
core/src/main/java/org/apache/oozie/servlet/BaseJobsServlet.java 95c65fe75
core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8fad98be9
core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 2d0ab6537
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java cba75df88
core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 85bfe4ba1
core/src/test/java/org/apache/oozie/TestBundleEngineSimple.java 90746e882
core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java c408d47ab
core/src/test/java/org/apache/oozie/TestFilterParser.java 49f47e2c0
core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e440c3a8d
core/src/test/java/org/apache/oozie/command/bundle/TestBulkBundleXCommand.java 8e63263e3
core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 36dded702
core/src/test/java/org/apache/oozie/command/coord/TestBulkCoordXCommand.java 27e294d44
core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 212cbbd51
core/src/test/java/org/apache/oozie/command/wf/TestBulkWorkflowXCommand.java a63ffd8f9
core/src/test/java/org/apache/oozie/executor/jpa/TestBulkMonitorJPAExecutor.java 23fe523eb
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java eb0d538f3
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 975bf3e7f
core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java 761345421
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 992f5666c
core/src/test/java/org/apache/oozie/service/TestZKUUIDService.java d1d75d7a4
Diff: https://reviews.apache.org/r/70111/diff/1/
Testing
-------
Unit tests using grind
Thanks,
Andras Salamon
Re: Review Request 70111: OOZIE-3335 Cleanup parseFilter methods
Posted by Andras Salamon <an...@melda.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70111/
-----------------------------------------------------------
(Updated March 25, 2019, 10:53 a.m.)
Review request for oozie and Kinga Marton.
Changes
-------
Rebased patch.
Repository: oozie-git
Description
-------
OOZIE-3335 Cleanup parseFilter methods
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/BundleEngine.java 19b54e6a0
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 07bab122e
core/src/main/java/org/apache/oozie/DagEngine.java 70ce96122
core/src/main/java/org/apache/oozie/FilterParser.java cd92a7c62
core/src/main/java/org/apache/oozie/FilterParserException.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java 587dbf9bb
core/src/main/java/org/apache/oozie/command/bundle/BulkBundleXCommand.java dbe70ae63
core/src/main/java/org/apache/oozie/command/bundle/BundleJobsXCommand.java 614e42290
core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java d3959019a
core/src/main/java/org/apache/oozie/command/coord/CoordJobsXCommand.java ba703f901
core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java ef3421d10
core/src/main/java/org/apache/oozie/command/wf/BulkWorkflowXCommand.java 0692a652d
core/src/main/java/org/apache/oozie/command/wf/JobsXCommand.java a82b03b57
core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 42961157a
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 6e1ea3e5b
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java 4c641d7e8
core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java 7797ff507
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java 795baabb3
core/src/main/java/org/apache/oozie/service/AuthorizationService.java 98fcc76c6
core/src/main/java/org/apache/oozie/servlet/BaseJobsServlet.java 95c65fe75
core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8fad98be9
core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 2d0ab6537
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java 74c65e866
core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 85bfe4ba1
core/src/test/java/org/apache/oozie/TestBundleEngineSimple.java 90746e882
core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java c408d47ab
core/src/test/java/org/apache/oozie/TestFilterParser.java 49f47e2c0
core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e440c3a8d
core/src/test/java/org/apache/oozie/command/bundle/TestBulkBundleXCommand.java 8e63263e3
core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 36dded702
core/src/test/java/org/apache/oozie/command/coord/TestBulkCoordXCommand.java 27e294d44
core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 212cbbd51
core/src/test/java/org/apache/oozie/command/wf/TestBulkWorkflowXCommand.java a63ffd8f9
core/src/test/java/org/apache/oozie/executor/jpa/TestBulkMonitorJPAExecutor.java 23fe523eb
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java eb0d538f3
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 975bf3e7f
core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java 761345421
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java ca7b30328
core/src/test/java/org/apache/oozie/service/TestZKUUIDService.java d1d75d7a4
Diff: https://reviews.apache.org/r/70111/diff/3/
Changes: https://reviews.apache.org/r/70111/diff/2-3/
Testing
-------
Unit tests using grind
Thanks,
Andras Salamon
Re: Review Request 70111: OOZIE-3335 Cleanup parseFilter methods
Posted by Andras Salamon <an...@melda.info>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70111/
-----------------------------------------------------------
(Updated March 7, 2019, 1:02 p.m.)
Review request for oozie and Kinga Marton.
Changes
-------
Addressing spotbugs issues
Repository: oozie-git
Description
-------
OOZIE-3335 Cleanup parseFilter methods
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/BundleEngine.java 19b54e6a0
core/src/main/java/org/apache/oozie/CoordinatorEngine.java 0aa56d1ef
core/src/main/java/org/apache/oozie/DagEngine.java 70ce96122
core/src/main/java/org/apache/oozie/FilterParser.java cd92a7c62
core/src/main/java/org/apache/oozie/FilterParserException.java PRE-CREATION
core/src/main/java/org/apache/oozie/command/BulkJobsXCommand.java 587dbf9bb
core/src/main/java/org/apache/oozie/command/bundle/BulkBundleXCommand.java dbe70ae63
core/src/main/java/org/apache/oozie/command/bundle/BundleJobsXCommand.java 614e42290
core/src/main/java/org/apache/oozie/command/coord/BulkCoordXCommand.java d3959019a
core/src/main/java/org/apache/oozie/command/coord/CoordJobsXCommand.java ba703f901
core/src/main/java/org/apache/oozie/command/coord/SLAEventsXCommand.java ef3421d10
core/src/main/java/org/apache/oozie/command/wf/BulkWorkflowXCommand.java 0692a652d
core/src/main/java/org/apache/oozie/command/wf/JobsXCommand.java a82b03b57
core/src/main/java/org/apache/oozie/executor/jpa/BulkJPAExecutor.java 42961157a
core/src/main/java/org/apache/oozie/executor/jpa/BundleJobInfoGetJPAExecutor.java 6e1ea3e5b
core/src/main/java/org/apache/oozie/executor/jpa/CoordJobInfoGetJPAExecutor.java 4c641d7e8
core/src/main/java/org/apache/oozie/executor/jpa/SLAEventsGetForFilterJPAExecutor.java 7797ff507
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowsJobGetJPAExecutor.java 45a893d20
core/src/main/java/org/apache/oozie/service/AuthorizationService.java 2c19aa29d
core/src/main/java/org/apache/oozie/servlet/BaseJobsServlet.java 95c65fe75
core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8fad98be9
core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 2d0ab6537
core/src/main/java/org/apache/oozie/store/StoreStatusFilter.java cba75df88
core/src/main/java/org/apache/oozie/util/JobsFilterUtils.java 85bfe4ba1
core/src/test/java/org/apache/oozie/TestBundleEngineSimple.java 90746e882
core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java c408d47ab
core/src/test/java/org/apache/oozie/TestFilterParser.java 49f47e2c0
core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e440c3a8d
core/src/test/java/org/apache/oozie/command/bundle/TestBulkBundleXCommand.java 8e63263e3
core/src/test/java/org/apache/oozie/command/bundle/TestBundleJobsXCommand.java 36dded702
core/src/test/java/org/apache/oozie/command/coord/TestBulkCoordXCommand.java 27e294d44
core/src/test/java/org/apache/oozie/command/coord/TestCoordJobsXCommand.java 212cbbd51
core/src/test/java/org/apache/oozie/command/wf/TestBulkWorkflowXCommand.java a63ffd8f9
core/src/test/java/org/apache/oozie/executor/jpa/TestBulkMonitorJPAExecutor.java 23fe523eb
core/src/test/java/org/apache/oozie/executor/jpa/TestBundleJobInfoGetJPAExecutor.java eb0d538f3
core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobInfoGetJPAExecutor.java 975bf3e7f
core/src/test/java/org/apache/oozie/executor/jpa/TestSLAEventsGetForFilterJPAExecutor.java 761345421
core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowsJobGetJPAExecutor.java 992f5666c
core/src/test/java/org/apache/oozie/service/TestZKUUIDService.java d1d75d7a4
Diff: https://reviews.apache.org/r/70111/diff/2/
Changes: https://reviews.apache.org/r/70111/diff/1-2/
Testing
-------
Unit tests using grind
Thanks,
Andras Salamon