You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/10/14 02:08:35 UTC
Review Request 39297: Added support for recovering RunState for HTTP
based executors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39297/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Repository: mesos
Description
-------
This change adds support for recovering the `RunState` for `HTTP` based executors. Upon agent recovery, it checks if the marker file for HTTP exists and populates `RunState.http` based on that. This is later used by the Agent for recovering `HTTP` based executors.
Diffs
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
Diff: https://reviews.apache.org/r/39297/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 39297: Added support for recovering RunState for
HTTP based executors
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39297/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 9:28 p.m.)
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Changes
-------
Review comments from Vinod
Repository: mesos
Description
-------
This change adds support for recovering the `RunState` for `HTTP` based executors. Upon agent recovery, it checks if the marker file for HTTP exists and populates `RunState.http` based on that. This is later used by the Agent for recovering `HTTP` based executors.
Diffs (updated)
-----
src/slave/state.hpp eb6b06cfcb5cd638f659035726f4e4e41fc5e017
src/slave/state.cpp bc46cc65af533639fcd556a8a65c509318702948
Diff: https://reviews.apache.org/r/39297/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 39297: Added support for recovering RunState for
HTTP based executors
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39297/#review108385
-----------------------------------------------------------
Ship it!
src/slave/state.cpp (lines 532 - 534)
<https://reviews.apache.org/r/39297/#comment167825>
Kill this. I don't think we do this for any other states that we recover?
src/slave/state.cpp (lines 546 - 547)
<https://reviews.apache.org/r/39297/#comment167826>
ditto. kill.
- Vinod Kone
On Nov. 10, 2015, 2:24 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39297/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 2:24 p.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds support for recovering the `RunState` for `HTTP` based executors. Upon agent recovery, it checks if the marker file for HTTP exists and populates `RunState.http` based on that. This is later used by the Agent for recovering `HTTP` based executors.
>
>
> Diffs
> -----
>
> src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
> src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
>
> Diff: https://reviews.apache.org/r/39297/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 39297: Added support for recovering RunState for
HTTP based executors
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39297/
-----------------------------------------------------------
(Updated Nov. 10, 2015, 2:24 p.m.)
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Changes
-------
Updated based on BenM's review comments on r38876
Repository: mesos
Description
-------
This change adds support for recovering the `RunState` for `HTTP` based executors. Upon agent recovery, it checks if the marker file for HTTP exists and populates `RunState.http` based on that. This is later used by the Agent for recovering `HTTP` based executors.
Diffs (updated)
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp d14159f5e8ca9957cbdcce53050b00a00dba2135
Diff: https://reviews.apache.org/r/39297/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 39297: Added support for recovering RunState for
HTTP based executors
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39297/
-----------------------------------------------------------
(Updated Nov. 7, 2015, 1:07 a.m.)
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Changes
-------
Modified Deps
Repository: mesos
Description
-------
This change adds support for recovering the `RunState` for `HTTP` based executors. Upon agent recovery, it checks if the marker file for HTTP exists and populates `RunState.http` based on that. This is later used by the Agent for recovering `HTTP` based executors.
Diffs
-----
src/slave/state.hpp 5a1a9bb2c86639612a8f065b7a66c8179696297a
src/slave/state.cpp 81c4b96d879fdddd974f0dfba3fb977184122eab
Diff: https://reviews.apache.org/r/39297/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar