You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jeremy Thomerson (JIRA)" <ji...@apache.org> on 2010/10/22 17:36:19 UTC
[jira] Resolved: (WICKET-3128) FormComponentLabel should open
open-close tags like Label does
[ https://issues.apache.org/jira/browse/WICKET-3128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jeremy Thomerson resolved WICKET-3128.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M3
1.4.13
Assignee: Jeremy Thomerson
Fixed in:
http://svn.apache.org/viewvc?view=rev&revision=1026375
http://svn.apache.org/viewvc?view=rev&revision=1026376
> FormComponentLabel should open open-close tags like Label does
> --------------------------------------------------------------
>
> Key: WICKET-3128
> URL: https://issues.apache.org/jira/browse/WICKET-3128
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4.12, 1.5-M2.1
> Reporter: Joonas Koivunen
> Assignee: Jeremy Thomerson
> Priority: Minor
> Fix For: 1.4.13, 1.5-M3
>
> Attachments: wicket-3128.patch
>
>
> Seems to affect all versions.
> FormComponentLabel nor it's subclass SimpleFormComponentLabel open the tag like Label does.
> While writing <label wicket:id="xyz"/> is invalid XHTML I'd argue this should be supported as Label will expand tags as well.
> FormComponentLabel asserts that the tags name is "label", so that's the reasoning behind implementing it there (in the patch attached).
> Patch is trivial and identical for both 1.4 and 1.5 branches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.