You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/03 19:52:29 UTC
[GitHub] [avro] KyleSchoonover opened a new pull request #1513: AVRO-3362 Changed DatumReader to IDatumReader
KyleSchoonover opened a new pull request #1513:
URL: https://github.com/apache/avro/pull/1513
## Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-3362
### Tests
- [ ] My PR does not need testing for this extremely good reason: non functional change
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1513: AVRO-3362 Changed DatumReader to IDatumReader
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1513:
URL: https://github.com/apache/avro/pull/1513#issuecomment-1030036194
Same as DatumWriter. I inherited the IDatumReader into DatumReader making it still useable to anyone who externally references it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on pull request #1513: AVRO-3362: Changed DatumReader to IDatumReader
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on pull request #1513:
URL: https://github.com/apache/avro/pull/1513#issuecomment-1034104324
@martin-g I believe we came to an agreement to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1513: AVRO-3362 Changed DatumReader to IDatumReader
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1513:
URL: https://github.com/apache/avro/pull/1513#issuecomment-1030049114
I agree with the change related to the compiler message. IMO it should be set in the codestyle file, instead of the actual source code with pragma.
The4 actual IDatumReader interface should be part of a major release and it makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia edited a comment on pull request #1513: AVRO-3362 Changed DatumReader to IDatumReader
Posted by GitBox <gi...@apache.org>.
zcsizmadia edited a comment on pull request #1513:
URL: https://github.com/apache/avro/pull/1513#issuecomment-1030049114
I agree with the change related to the compiler message. IMO it should be set in the codestyle file, instead of the actual source code with pragma.
The actual IDatumReader interface should be part of a major release and it makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1513: AVRO-3362: Changed DatumReader to IDatumReader
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1513:
URL: https://github.com/apache/avro/pull/1513#issuecomment-1034109681
Personally I dont think this should be merged, unless part of a major release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover closed pull request #1513: AVRO-3362: Changed DatumReader to IDatumReader
Posted by GitBox <gi...@apache.org>.
KyleSchoonover closed pull request #1513:
URL: https://github.com/apache/avro/pull/1513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org