[GitHub] [incubator-doris] yangzhg commented on a diff in pull request #9307: [refactor][storage]rename is_used to is_bad

[GitBox <gi...@apache.org>]

yangzhg commented on code in PR #9307:
URL: https://github.com/apache/incubator-doris/pull/9307#discussion_r861407829


##########
be/src/olap/data_dir.h:
##########
@@ -54,8 +54,8 @@ class DataDir {
     const std::string& path() const { return _path_desc.filepath; }
     const FilePathDesc& path_desc() const { return _path_desc; }
     size_t path_hash() const { return _path_hash; }
-    bool is_used() const { return _is_used; }
-    void set_is_used(bool is_used) { _is_used = is_used; }
+    bool is_bad() const { return _is_bad; }
+    void set_is_bad(bool is_bad) { _is_bad = is_bad; }

Review Comment:
   - I think bad() and set_bad() is enough no need is



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org