You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/15 08:58:03 UTC

[GitHub] [camel] rmannibucau opened a new pull request #4451: [CAMEL-15691] ensure johnzon format doc does not inherit inaccurate jackson doc

rmannibucau opened a new pull request #4451:
URL: https://github.com/apache/camel/pull/4451


   - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #4451: [CAMEL-15691] ensure johnzon format doc does not inherit inaccurate jackson doc

Posted by GitBox <gi...@apache.org>.

davsclaus commented on pull request #4451:
URL: https://github.com/apache/camel/pull/4451#issuecomment-709169540


   Yeah data formats are special and then those json data formats even more as they inherit a bit from each other.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus merged pull request #4451: [CAMEL-15691] ensure johnzon format doc does not inherit inaccurate jackson doc

Posted by GitBox <gi...@apache.org>.

davsclaus merged pull request #4451:
URL: https://github.com/apache/camel/pull/4451


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] rmannibucau commented on pull request #4451: [CAMEL-15691] ensure johnzon format doc does not inherit inaccurate jackson doc

Posted by GitBox <gi...@apache.org>.

rmannibucau commented on pull request #4451:
URL: https://github.com/apache/camel/pull/4451#issuecomment-709053302


   @oscerd hmm, not sure i'm following, the setter is in JsonDataFormat (grabbed by the plugin cause johnzon is a json dataformat) - and you likely don't want I write something specific about Johnzon I guess even if it had been done historically for jackson ;); The opposite is true for JohnzonDataFormat where I don't want to add a setObjectMapper(String) to do the lookup myself to ensure I inherit from org.apache.camel.reifier.dataformat.DataFormatReifier#configureDataFormat to do it in an unified way. What do I miss?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on pull request #4451: [CAMEL-15691] ensure johnzon format doc does not inherit inaccurate jackson doc

Posted by GitBox <gi...@apache.org>.

oscerd commented on pull request #4451:
URL: https://github.com/apache/camel/pull/4451#issuecomment-709059159


   What I meant was just that the mapper description is autogenerated starting from
   https://github.com/apache/camel/blob/master/core/camel-core-engine/src/main/java/org/apache/camel/model/dataformat/JsonDataFormat.java#L101
   
   So if you wanted to have effective change in the documentation, you'll need to modify the javadoc accordingly. Otherwise at the next build the documentation would have been overriden. But I saw you workarounded this through the packageDataformatMojo, which should work anyway. So that's fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org