[GitHub] [phoenix] ramatronics commented on pull request #1280: PHOENIX-6523: Support for HRpc connection protocol through JDBC URL

[GitBox <gi...@apache.org>]

ramatronics commented on pull request #1280:
URL: https://github.com/apache/phoenix/pull/1280#issuecomment-901534582


   > to understand what is in scope and what's out of scope
   
   The scope right now is to support HBase registry _if specified_ or else always default to ZK. I think the most important thing here is to ensure there's no regression to existing connections. This HRpc thing should be treated as an opt-in, else we should preserve the same behaviour as before.
   
   > I'm assuming you don't want to try to support any registry, but it might be a good idea to keep that in mind so as to not code ourselves into a corner.
   
   I think using some OOP to clean the classes up as you suggested is a good foundation to set for other registries down the road


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org