You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/03/01 21:04:21 UTC
Review Request 44224: Set `MESOS_SHUTDOWN_GRACE_PERIOD` in agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44224/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
Bugs: MESOS-4829
https://issues.apache.org/jira/browse/MESOS-4829
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
Diff: https://reviews.apache.org/r/44224/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 44224: Set `MESOS_SHUTDOWN_GRACE_PERIOD` in agent.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44224/#review121486
-----------------------------------------------------------
src/slave/containerizer/containerizer.cpp (line 332)
<https://reviews.apache.org/r/44224/#comment183204>
s/MESOS_SHUTDOWN_GRACE_PERIOD/MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD/
to match the flag name.
- Vinod Kone
On March 1, 2016, 8:04 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44224/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 8:04 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-4829
> https://issues.apache.org/jira/browse/MESOS-4829
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
>
> Diff: https://reviews.apache.org/r/44224/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 44224: Set `MESOS_SHUTDOWN_GRACE_PERIOD` in agent.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44224/#review121497
-----------------------------------------------------------
Ship it!
Can you update the title to reflect the new env name?
- Vinod Kone
On March 1, 2016, 9:15 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44224/
> -----------------------------------------------------------
>
> (Updated March 1, 2016, 9:15 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
>
>
> Bugs: MESOS-4829
> https://issues.apache.org/jira/browse/MESOS-4829
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
>
> Diff: https://reviews.apache.org/r/44224/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 44224: Set `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD`
in agent.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44224/
-----------------------------------------------------------
(Updated March 1, 2016, 9:27 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
Changes
-------
Updated summary.
Summary (updated)
-----------------
Set `MESOS_EXECUTOR_SHUTDOWN_GRACE_PERIOD` in agent.
Bugs: MESOS-4829
https://issues.apache.org/jira/browse/MESOS-4829
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
Diff: https://reviews.apache.org/r/44224/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 44224: Set `MESOS_SHUTDOWN_GRACE_PERIOD` in agent.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44224/
-----------------------------------------------------------
(Updated March 1, 2016, 9:15 p.m.)
Review request for mesos, Alexander Rukletsov, Ben Mahler, and Vinod Kone.
Changes
-------
Renamed environment variable.
Bugs: MESOS-4829
https://issues.apache.org/jira/browse/MESOS-4829
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/slave/containerizer/containerizer.cpp 59904684cdeb17ef2b42092a3558802c42bfb6bd
Diff: https://reviews.apache.org/r/44224/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar