[jira] Commented: (TAP5-760) The Form event "validateForm" is awkward, just "validate" should do

["Howard M. Lewis Ship (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAP5-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799520#action_12799520 ] 

Howard M. Lewis Ship commented on TAP5-760:
-------------------------------------------

I agree ... individual form element components will fire validate events, and now the Form will as well (validateForm is being kept for compatibility). These are events you would always qualify with the component id, so there never really was a reason for validateForm in the first place.

> The Form event "validateForm" is awkward, just "validate" should do
> -------------------------------------------------------------------
>
>                 Key: TAP5-760
>                 URL: https://issues.apache.org/jira/browse/TAP5-760
>             Project: Tapestry 5
>          Issue Type: Improvement
>          Components: tapestry-core
>    Affects Versions: 5.1.0.5
>            Reporter: Howard M. Lewis Ship
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>
> You end up with methods like onValidateFormFromLogin() which is just asking for trouble.
> onFormValidateFromLogin() is a bit better.
> Obviously, we keep the old name as well ... have to fire two events at the validate form stage.
> What would be a better name?  Something that doesn't have "form" is it; perhaps "finalValidation" or just "validate". I remember this was a problem with calling it "validate" before, because this conflicted with the validate event form form control element components ... but is that really a problem?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.