You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/18 18:25:08 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7129: arch/arm: Unify arm_cpu_sgi to up_trigger_irq
xiaoxiang781216 opened a new pull request, #7129:
URL: https://github.com/apache/incubator-nuttx/pull/7129
## Summary
Make the API consistent between armv7-a/r and armv7/8-m
## Impact
arm
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7129: arch/armv7[a|r]: Implement up_affinity_irq
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7129:
URL: https://github.com/apache/incubator-nuttx/pull/7129#issuecomment-1251850814
@xiaoxiang781216
During testing this PR with sabre-6quad:netknsh_smp on QEMU-6.2, I noticed performance degradation.
Without this PR
```
nsh> iperf -s
IP: 10.0.2.15
mode=tcp-server sip=10.0.2.15:5001,dip=0.0.0.0:5001, interval=3, time=0
accept: 10.0.2.2,45746
Interval Transfer Bandwidth
0.00- 3.01 sec 41823160 Bytes 111.16 Mbits/sec
3.01- 6.03 sec 83822980 Bytes 111.26 Mbits/sec
6.03- 9.04 sec 125957120 Bytes 111.98 Mbits/sec
9.04- 12.05 sec 168108780 Bytes 112.03 Mbits/sec
12.05- 15.06 sec 210590400 Bytes 112.91 Mbits/sec
15.06- 18.07 sec 253308540 Bytes 113.54 Mbits/sec
18.07- 21.08 sec 296190200 Bytes 113.97 Mbits/sec
21.08- 24.09 sec 337715520 Bytes 110.37 Mbits/sec
24.09- 27.10 sec 380080340 Bytes 112.60 Mbits/sec
27.10- 30.11 sec 422694820 Bytes 113.26 Mbits/sec
30.11- 33.12 sec 464328180 Bytes 110.65 Mbits/sec
33.12- 36.13 sec 506558680 Bytes 112.24 Mbits/sec
36.13- 39.14 sec 549304560 Bytes 113.61 Mbits/sec
```
With this PR.
```
nsh> iperf -s
IP: 10.0.2.15
mode=tcp-server sip=10.0.2.15:5001,dip=0.0.0.0:5001, interval=3, time=0
accept: 10.0.2.2,45800
Interval Transfer Bandwidth
0.00- 3.01 sec 33917260 Bytes 90.15 Mbits/sec
3.01- 6.03 sec 70001160 Bytes 95.59 Mbits/sec
6.03- 9.04 sec 105947820 Bytes 95.54 Mbits/sec
9.04- 12.05 sec 141693000 Bytes 95.00 Mbits/sec
12.05- 15.06 sec 177392920 Bytes 94.88 Mbits/sec
15.06- 18.07 sec 213304540 Bytes 95.45 Mbits/sec
18.07- 21.08 sec 248973800 Bytes 94.80 Mbits/sec
21.08- 24.09 sec 284562760 Bytes 94.59 Mbits/sec
24.09- 27.10 sec 319335580 Bytes 92.42 Mbits/sec
27.10- 30.11 sec 353915680 Bytes 91.91 Mbits/sec
30.11- 33.12 sec 388157060 Bytes 91.01 Mbits/sec
33.12- 36.13 sec 422401360 Bytes 91.01 Mbits/sec
36.13- 39.14 sec 456855900 Bytes 91.57 Mbits/sec
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 merged pull request #7129: arch/armv7[a|r]: Implement up_affinity_irq
Posted by GitBox <gi...@apache.org>.
masayuki2009 merged PR #7129:
URL: https://github.com/apache/incubator-nuttx/pull/7129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7129: arch/armv7[a|r]: Implement up_affinity_irq
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7129:
URL: https://github.com/apache/incubator-nuttx/pull/7129#issuecomment-1251860453
@masayuki2009 I refine the implementation, the performance should keep as before now. Could you verify again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7129: arch/armv7[a|r]: Implement up_affinity_irq
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7129:
URL: https://github.com/apache/incubator-nuttx/pull/7129#issuecomment-1251887445
>I wonder the performance difference on the real device.
I still have an issue with AR8031 gigabit ethernet PHY.
So I can not run the iperf on the real device.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7129: arch/armv7[a|r]: Implement up_affinity_irq
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7129:
URL: https://github.com/apache/incubator-nuttx/pull/7129#issuecomment-1251862218
> @xiaoxiang781216
>
> During testing this PR with sabre-6quad:netknsh_smp on QEMU-6.2, I noticed performance degradation.
>
I wonder the performance difference on the real device。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7129: arch/armv7[a|r]: Implement up_affinity_irq
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on PR #7129:
URL: https://github.com/apache/incubator-nuttx/pull/7129#issuecomment-1251942407
@xiaoxiang781216
The latest PR looks fine.
```
nsh> iperf -s
IP: 10.0.2.15
mode=tcp-server sip=10.0.2.15:5001,dip=0.0.0.0:5001, interval=3, time=0
accept: 10.0.2.2,46940
Interval Transfer Bandwidth
0.00- 3.02 sec 41801260 Bytes 110.73 Mbits/sec
3.02- 6.03 sec 83928100 Bytes 111.97 Mbits/sec
6.03- 9.04 sec 125476780 Bytes 110.43 Mbits/sec
9.04- 12.05 sec 167697060 Bytes 112.21 Mbits/sec
12.05- 15.06 sec 209656000 Bytes 111.52 Mbits/sec
15.06- 18.07 sec 251782840 Bytes 111.97 Mbits/sec
18.07- 21.08 sec 293632280 Bytes 111.23 Mbits/sec
21.08- 24.09 sec 335680280 Bytes 111.76 Mbits/sec
24.09- 27.10 sec 378382360 Bytes 113.49 Mbits/sec
27.10- 30.11 sec 420328160 Bytes 111.48 Mbits/sec
30.11- 33.12 sec 462348420 Bytes 111.68 Mbits/sec
33.12- 36.13 sec 504412480 Bytes 111.80 Mbits/sec
36.13- 39.14 sec 546863440 Bytes 112.83 Mbits/sec
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org