[jira] [Commented] (SOLR-14937) client.queryDefaults().set(...) misunderstanding in JSON facet tests

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224727#comment-17224727 ] 

ASF subversion and git services commented on SOLR-14937:
--------------------------------------------------------

Commit aabbbdc928a1e74510c3526ebb31f2e7a88bdac1 in lucene-solr's branch refs/heads/branch_8x from Christine Poerschke
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=aabbbdc ]

SOLR-14937: Correct client.queryDefaults().set(...) calls in some JSON facet tests. (#2031)



> client.queryDefaults().set(...) misunderstanding in JSON facet tests
> --------------------------------------------------------------------
>
>                 Key: SOLR-14937
>                 URL: https://issues.apache.org/jira/browse/SOLR-14937
>             Project: Solr
>          Issue Type: Test
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> I noticed today that we have
> {code:java}
> client.queryDefaults().set("shards", "foo", "debugQuery", "bar");
> {code}
> style usage in some tests and whilst this was likely intended to result in
> {code:java}
> { "shards" : "foo", "debugQuery" : "bar" }
> {code}
> query defaults it actually results in
> {code:java}
> { "shards" : [ "foo", "debugQuery" , "bar" ] }
> {code}
> query defaults based on the {{ModifiableSolrParams.set}} implementation: [https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.6.3/solr/solrj/src/java/org/apache/solr/common/params/ModifiableSolrParams.java#L86-L96]
> A possible alternative is
> {code:java}
> client.queryDefaults().set("shards", "foo").set("debugQuery", "bar");
> {code}
> style usage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org