[GitHub] [cloudstack] weizhouapache commented on pull request #6177: UI: fix update public IP ranges

[GitBox <gi...@apache.org>]

weizhouapache commented on pull request #6177:
URL: https://github.com/apache/cloudstack/pull/6177#issuecomment-1081736612


   > @weizhouapache would it be better to call `this.initAddIpRangeForm()` in `created()` to maintain consistency with other forms?
   
   @Pearl1594 
   it looks not needed. the two forms use different variables.
   
   ```
       initAddIpRangeForm () {
         this.formRef = ref()
         this.form = reactive({})
         this.rules = reactive({
           podid: [{ required: true, message: this.$t('label.required') }],
           gateway: [{ required: true, message: this.$t('label.required') }],
           netmask: [{ required: true, message: this.$t('label.required') }],
           startip: [{ required: true, message: this.$t('label.required') }],
           endip: [{ required: true, message: this.$t('label.required') }]
         })
       },
       initFormUpdateRange () {
         this.updRangeRef = ref()
         this.formUpdRange = reactive({})
         this.updRangeRules = reactive({
           startip: [{ required: true, message: this.$t('label.required') }],
           endip: [{ required: true, message: this.$t('label.required') }],
           gateway: [{ required: true, message: this.$t('label.required') }],
           netmask: [{ required: true, message: this.$t('label.required') }]
         })
       },
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org