[GitHub] [incubator-paimon] yuzelin commented on a diff in pull request #2078: [cdc] Optimize Duplicate Field Detection in MySQL CDC Schema Building.

["yuzelin (via GitHub)" <gi...@apache.org>]

yuzelin commented on code in PR #2078:
URL: https://github.com/apache/incubator-paimon/pull/2078#discussion_r1339449387


##########
paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/CdcActionCommonUtils.java:
##########
@@ -140,8 +140,9 @@ public static String columnCaseConvertAndDuplicateCheck(
         if (caseSensitive) {
             return column;
         }
-        checkArgument(existedFields.add(column.toLowerCase()), columnDuplicateErrMsg.apply(column));
-        return column.toLowerCase();

Review Comment:
   Here I think we can keep the filed name case in error message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org