[GitHub] [pinot] walterddr commented on a diff in pull request #9086: Proper null handling in Aggregation functions for SV data types

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #9086:
URL: https://github.com/apache/pinot/pull/9086#discussion_r933874101


##########
pinot-common/src/main/java/org/apache/pinot/common/request/context/RequestContextUtils.java:
##########
@@ -95,6 +90,9 @@ public static FunctionContext getFunction(Function thriftFunction) {
       for (Expression operand : operands) {
         arguments.add(getExpression(operand));
       }
+      if (arguments.size() == 0 && functionName.equalsIgnoreCase(AggregationFunctionType.COUNT.getName())) {

Review Comment:
   ok yeah so that pinot-server expects a * on count. got it I can make the fix. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org