You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Martin Kraemer <ma...@mch.sni.de> on 1999/02/16 13:26:29 UTC
Re: [PATCH] 500 errors not giving error-notes (related to PR #3455)
On Mon, Jan 25, 1999 at 10:59:35AM -0800, Cliff Skolnick wrote:
> +++ http_protocol.c 1999/01/25 10:01:37
> + if (((error_notes = ap_table_get(r->notes, "error-notes")) != NULL)
> + && (strncmp(ap_table_get(r->notes, "verbose-error-to"), "*", 1)
Why not strcmp()? If the asterisk is the only thing that is checked for
general applicability of the error-notes string, then strcmp() would be
sufficient.
> +++ proxy_util.c 1999/01/25 10:02:07
> @@ -842,6 +842,7 @@
> "<EM><A HREF=\"", r->uri, "\">",
> r->method, " ", r->uri, "</A></EM>.<P>\n"
> "Reason: <STRONG>", message, "</STRONG>", NULL));
> + ap_table_setn(r->notes, "verbose-error-to", ap_pstrcat(r->pool, "*"));
^^^^^^^^^^^^^^^^^^^^^^^
This probably was meant to read ap_pstrdup()...
Good idea. +1 with the strdup() modification above.
Martin
--
<Ma...@MchP.Siemens.De> | Siemens Information and
Phone: +49-89-636-46021 | Communication Products
FAX: +49-89-636-47816 | 81730 Munich, Germany