[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #9923: ARROW-12246: [CI] Sync conda recipes with upstream feedstock

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on a change in pull request #9923:
URL: https://github.com/apache/arrow/pull/9923#discussion_r611835054



##########
File path: dev/tasks/conda-recipes/arrow-cpp/meta.yaml
##########
@@ -1,6 +1,6 @@
-{% set version = "3.0.0" %}
+{% set version = ARROW_VERSION %}

Review comment:
       Maybe can add a comment here indicating that setting this to `ARROW_VERSION` is a difference compared to the upstream version?

##########
File path: dev/tasks/conda-recipes/arrow-cpp/bld-pyarrow.bat
##########
@@ -1,16 +1,17 @@
+@echo on
 pushd "%SRC_DIR%"\python
 
 @rem the symlinks for cmake modules don't work here
-del cmake_modules\BuildUtils.cmake
-del cmake_modules\SetupCxxFlags.cmake
-del cmake_modules\CompilerInfo.cmake
-del cmake_modules\FindNumPy.cmake
-del cmake_modules\FindPythonLibsNew.cmake
-copy /Y "%SRC_DIR%\cpp\cmake_modules\BuildUtils.cmake" cmake_modules\
-copy /Y "%SRC_DIR%\cpp\cmake_modules\SetupCxxFlags.cmake" cmake_modules\
-copy /Y "%SRC_DIR%\cpp\cmake_modules\CompilerInfo.cmake" cmake_modules\
-copy /Y "%SRC_DIR%\cpp\cmake_modules\FindNumPy.cmake" cmake_modules\
-copy /Y "%SRC_DIR%\cpp\cmake_modules\FindPythonLibsNew.cmake" cmake_modules\
+@rem del cmake_modules\BuildUtils.cmake

Review comment:
       Worth adding a comment that those are commented out compared to the upstream conda-forge build script?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org