You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/10/22 13:44:27 UTC
[GitHub] [iceberg] marton-bod opened a new pull request #1645: Small changes to prepare mr test code to work with Hive4 as well
marton-bod opened a new pull request #1645:
URL: https://github.com/apache/iceberg/pull/1645
A few small changes to make the test code work equally with Hive3 or Hive4 dependencies.
@rdblue @pvary Can you please take a look? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1645: Small changes to prepare mr test code to work with Hive4 as well
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1645:
URL: https://github.com/apache/iceberg/pull/1645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] marton-bod commented on pull request #1645: Small changes to prepare mr test code to work with Hive4 as well
Posted by GitBox <gi...@apache.org>.
marton-bod commented on pull request #1645:
URL: https://github.com/apache/iceberg/pull/1645#issuecomment-716510832
Thanks for reviewing @rdblue !
While the test failures were resolved by simply disabling scheduled query executions (as in f01bd91), the real problem turned out to be that the background metastore tasks were not shut down properly between test suites and stale tasks kept on being scheduled. I've added a fix for that and a comment to explain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1645: Small changes to prepare mr test code to work with Hive4 as well
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1645:
URL: https://github.com/apache/iceberg/pull/1645#issuecomment-715501653
Looks good to me, I'd just like to understand why the property change is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1645: Small changes to prepare mr test code to work with Hive4 as well
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1645:
URL: https://github.com/apache/iceberg/pull/1645#discussion_r511060853
##########
File path: hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -190,6 +190,7 @@ private HiveConf newHiveConf(int port) {
newHiveConf.set(HiveConf.ConfVars.METASTOREWAREHOUSE.varname, "file:" + hiveLocalDir.getAbsolutePath());
newHiveConf.set(HiveConf.ConfVars.METASTORE_TRY_DIRECT_SQL.varname, "false");
newHiveConf.set(HiveConf.ConfVars.METASTORE_DISALLOW_INCOMPATIBLE_COL_TYPE_CHANGES.varname, "false");
+ newHiveConf.set("metastore.scheduled.queries.enabled", "false");
Review comment:
Why is this needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org