[jira] [Commented] (ISIS-552) Upgrade to Wicket 6.10.0 introduced interference between required text fields and the Wicket viewer's veil.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783721#comment-13783721 ] 

ASF subversion and git services commented on ISIS-552:
------------------------------------------------------

Commit 1d985994457ded901d6e8e2df9668e81b40a7b25 in branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=1d98599 ]

ISIS-552: prevent Chrome required popup from appearing...

... was interfering with Wicket viewer's veil

In addition, some minor cosmetic improvements for the ToDo app, showing how custom CSS classes can be picked out using application.css


> Upgrade to Wicket 6.10.0 introduced interference between required text fields and the Wicket viewer's veil.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: ISIS-552
>                 URL: https://issues.apache.org/jira/browse/ISIS-552
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: Wicket
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: viewer-wicket-1.3.0
>
>
> Specifically, Wicket 6.10.0 (per https://issues.apache.org/jira/browse/WICKET-5289) now sets the HTML5 "required" attribute.  This causes HTML5 browsers such as Chrome to display a client-side pop-up.
> When the OK button is clicked, the Wicket viewer always displays the veil (see jquery.isis.viewer.wicket.js), and relies upon a page refresh to clear the veil.
> However, because the page is never submitted, the veil does not disappear.  The only workaround is to resubmit the page, thus losing any text that might have been entered.
> This fix is to prevent Chrome from showing the pop-up by *not* setting the required flag in the Wicket viewer.
> ~~~
> An alternative solutino - that would preserve the pop-up - would be to change the way that the veil is rendered, by associating the Javascript callback with form.submit() rather than button.click().



--
This message was sent by Atlassian JIRA
(v6.1#6144)