[jira] [Commented] (FLINK-3113) Remove unused global order methods from GenericDataSinkBase

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041573#comment-15041573 ] 

ASF GitHub Bot commented on FLINK-3113:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/1435

    [FLINK-3113] Remove unused and unsupported global-order methods from GenericDataSinkBase

    Methods are unused and not supported by DataSet API.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink globalOrderSinkCleanUp

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1435.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1435
    
----
commit ff618fb6e9b2359c3c5fe9f63c7de30723aa5644
Author: Fabian Hueske <fh...@apache.org>
Date:   2015-12-04T12:10:33Z

    [FLINK-3113] Remove unused and unsupported global-order methods from GenericDataSinkBase

----


> Remove unused global order methods from GenericDataSinkBase
> -----------------------------------------------------------
>
>                 Key: FLINK-3113
>                 URL: https://issues.apache.org/jira/browse/FLINK-3113
>             Project: Flink
>          Issue Type: Task
>          Components: Core
>    Affects Versions: 1.0.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> The {{GenericDataSinkBase}} class has unused methods to specify a global order. These methods are an artifact of the recently removed Record API and not suitable for the current DataSet API because they lack the definition of a key.
> The following methods and fields should be removed from {{GenericDataSinkBase}}
> - {{partitioningOrdering}}
> - {{distribution}}
> - {{setGlobalOrder()}}
> - {{setRangePartitioned()}}
> - {{getPartitiningOrdering()}}
> - {{getDataDistribution()}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)