You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/03 05:57:35 UTC

[GitHub] [iotdb] 23931017wu commented on a diff in pull request #7745: [IOTDB-4769] When modifying an alias, you need to add back quotes when the alias is a special character.

23931017wu commented on code in PR #7745:
URL: https://github.com/apache/iotdb/pull/7745#discussion_r1012523815


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/parser/ASTVisitor.java:
##########
@@ -1664,10 +1664,14 @@ private String parseNodeString(String nodeName) {
     }
     if (nodeName.startsWith(TsFileConstant.BACK_QUOTE_STRING)
         && nodeName.endsWith(TsFileConstant.BACK_QUOTE_STRING)) {
-      String unWrapped = nodeName.substring(1, nodeName.length() - 1);
+      String unWrapped =
+          nodeName
+              .substring(1, nodeName.length() - 1)
+              .replace(TsFileConstant.DOUBLE_BACK_QUOTE_STRING, TsFileConstant.BACK_QUOTE_STRING);
+      ;

Review Comment:
   This is to solve the problem that the double back quotes in the node path do not resolve to single quotes.
   
   ![图片](https://user-images.githubusercontent.com/71131924/199655789-afc53a07-741f-495d-878b-ae42b49c0395.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org