You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@camel.apache.org by "Erker, Carsten" <Ca...@akquinet.de> on 2013/06/18 18:23:47 UTC

Problem with Camel FTP component because of bug in commons-net

Hi,

I just stumbled upon a bug in Apache Commons Net 3.2 / FTPClient. The bug is known and fixed in Commons Net 3.3: https://issues.apache.org/jira/browse/NET-502

The problem was with the FTP producer, when after putting a file to the server, I got a 5xx error as Camel tries to change back to the current working dir (see FtpOperations.storeFile()). 
This happened due to incorrect parsing of the reply from a PWD in FTPClient.__parsePathname() when getting the current working dir.

For a first work-around I excluded the commons-net:3.2 dependency of camel-ftp in my Maven setup and added a dependency to commons-net:3.3.

Since this is quite a fundamental bug, it would be great if Camel-FTP would be upgraded to use the current version of commons-net with the next Camel release.

Regards
Carsten

Re: Problem with Camel FTP component because of bug in commons-net

Posted by Claus Ibsen <cl...@gmail.com>.
Hi

I logged a ticket about the 3.3 upgrade
https://issues.apache.org/jira/browse/CAMEL-6487

On Wed, Jun 19, 2013 at 1:18 PM, Christian Müller
<ch...@gmail.com> wrote:
> The linked commons-net issue [1] is fixed in version 3.3. So, upgrading to
> commons-net 3.3 SHOULD fix this issue.
> However, it would be good if we could add first a unit test which shows
> this issue with commons-net 3.2 and Camel 2.11.x/2.12.x so that we can make
> sure we fixed this issue and do not run into the same issue in a further
> release...
>
> [1] https://issues.apache.org/jira/browse/NET-492
>
> My 0,02 €,
>
> Christian Müller
> -----------------
>
> Software Integration Specialist
>
> Apache Camel committer: https://camel.apache.org/team
> V.P. Apache Camel: https://www.apache.org/foundation/
> Apache Member: https://www.apache.org/foundation/members.html
>
> https://www.linkedin.com/pub/christian-mueller/11/551/642
>
>
> On Wed, Jun 19, 2013 at 11:16 AM, Erker, Carsten
> <Ca...@akquinet.de>wrote:
>
>>
>> Hi Claus,
>>
>> after checking again I found this definitely relates to CAMEL-6219.
>>
>> As of now, we only got a simple FTP route where commons-net-3.3 works fine.
>> I can offer running the Camel tests with 3.3 and adding a test case for
>> the specific issue, however this will not be before the end of next week.
>>
>>
>>
>> Am 19.06.2013 um 09:13 schrieb Claus Ibsen:
>>
>> > Hi
>> >
>> > Ah thanks. We downgraded to 3.1 as that was working well.
>> > Are you sure 3.3 works fine?
>> >
>> > On Tue, Jun 18, 2013 at 6:23 PM, Erker, Carsten
>> > <Ca...@akquinet.de> wrote:
>> >> Hi,
>> >>
>> >> I just stumbled upon a bug in Apache Commons Net 3.2 / FTPClient. The
>> bug is known and fixed in Commons Net 3.3:
>> https://issues.apache.org/jira/browse/NET-502
>> >>
>> >> The problem was with the FTP producer, when after putting a file to the
>> server, I got a 5xx error as Camel tries to change back to the current
>> working dir (see FtpOperations.storeFile()).
>> >> This happened due to incorrect parsing of the reply from a PWD in
>> FTPClient.__parsePathname() when getting the current working dir.
>> >>
>> >> For a first work-around I excluded the commons-net:3.2 dependency of
>> camel-ftp in my Maven setup and added a dependency to commons-net:3.3.
>> >>
>> >> Since this is quite a fundamental bug, it would be great if Camel-FTP
>> would be upgraded to use the current version of commons-net with the next
>> Camel release.
>> >>
>> >> Regards
>> >> Carsten
>> >
>> >
>> >
>> > --
>> > Claus Ibsen
>> > -----------------
>> > www.camelone.org: The open source integration conference.
>> >
>> > Red Hat, Inc.
>> > FuseSource is now part of Red Hat
>> > Email: cibsen@redhat.com
>> > Web: http://fusesource.com
>> > Twitter: davsclaus
>> > Blog: http://davsclaus.com
>> > Author of Camel in Action: http://www.manning.com/ibsen
>>
>>



-- 
Claus Ibsen
-----------------
www.camelone.org: The open source integration conference.

Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen

Re: Problem with Camel FTP component because of bug in commons-net

Posted by Christian Müller <ch...@gmail.com>.
The linked commons-net issue [1] is fixed in version 3.3. So, upgrading to
commons-net 3.3 SHOULD fix this issue.
However, it would be good if we could add first a unit test which shows
this issue with commons-net 3.2 and Camel 2.11.x/2.12.x so that we can make
sure we fixed this issue and do not run into the same issue in a further
release...

[1] https://issues.apache.org/jira/browse/NET-492

My 0,02 €,

Christian Müller
-----------------

Software Integration Specialist

Apache Camel committer: https://camel.apache.org/team
V.P. Apache Camel: https://www.apache.org/foundation/
Apache Member: https://www.apache.org/foundation/members.html

https://www.linkedin.com/pub/christian-mueller/11/551/642


On Wed, Jun 19, 2013 at 11:16 AM, Erker, Carsten
<Ca...@akquinet.de>wrote:

>
> Hi Claus,
>
> after checking again I found this definitely relates to CAMEL-6219.
>
> As of now, we only got a simple FTP route where commons-net-3.3 works fine.
> I can offer running the Camel tests with 3.3 and adding a test case for
> the specific issue, however this will not be before the end of next week.
>
>
>
> Am 19.06.2013 um 09:13 schrieb Claus Ibsen:
>
> > Hi
> >
> > Ah thanks. We downgraded to 3.1 as that was working well.
> > Are you sure 3.3 works fine?
> >
> > On Tue, Jun 18, 2013 at 6:23 PM, Erker, Carsten
> > <Ca...@akquinet.de> wrote:
> >> Hi,
> >>
> >> I just stumbled upon a bug in Apache Commons Net 3.2 / FTPClient. The
> bug is known and fixed in Commons Net 3.3:
> https://issues.apache.org/jira/browse/NET-502
> >>
> >> The problem was with the FTP producer, when after putting a file to the
> server, I got a 5xx error as Camel tries to change back to the current
> working dir (see FtpOperations.storeFile()).
> >> This happened due to incorrect parsing of the reply from a PWD in
> FTPClient.__parsePathname() when getting the current working dir.
> >>
> >> For a first work-around I excluded the commons-net:3.2 dependency of
> camel-ftp in my Maven setup and added a dependency to commons-net:3.3.
> >>
> >> Since this is quite a fundamental bug, it would be great if Camel-FTP
> would be upgraded to use the current version of commons-net with the next
> Camel release.
> >>
> >> Regards
> >> Carsten
> >
> >
> >
> > --
> > Claus Ibsen
> > -----------------
> > www.camelone.org: The open source integration conference.
> >
> > Red Hat, Inc.
> > FuseSource is now part of Red Hat
> > Email: cibsen@redhat.com
> > Web: http://fusesource.com
> > Twitter: davsclaus
> > Blog: http://davsclaus.com
> > Author of Camel in Action: http://www.manning.com/ibsen
>
>

Re: Problem with Camel FTP component because of bug in commons-net

Posted by "Erker, Carsten" <Ca...@akquinet.de>.
Hi Claus,

after checking again I found this definitely relates to CAMEL-6219.

As of now, we only got a simple FTP route where commons-net-3.3 works fine. 
I can offer running the Camel tests with 3.3 and adding a test case for the specific issue, however this will not be before the end of next week.



Am 19.06.2013 um 09:13 schrieb Claus Ibsen:

> Hi
> 
> Ah thanks. We downgraded to 3.1 as that was working well.
> Are you sure 3.3 works fine?
> 
> On Tue, Jun 18, 2013 at 6:23 PM, Erker, Carsten
> <Ca...@akquinet.de> wrote:
>> Hi,
>> 
>> I just stumbled upon a bug in Apache Commons Net 3.2 / FTPClient. The bug is known and fixed in Commons Net 3.3: https://issues.apache.org/jira/browse/NET-502
>> 
>> The problem was with the FTP producer, when after putting a file to the server, I got a 5xx error as Camel tries to change back to the current working dir (see FtpOperations.storeFile()).
>> This happened due to incorrect parsing of the reply from a PWD in FTPClient.__parsePathname() when getting the current working dir.
>> 
>> For a first work-around I excluded the commons-net:3.2 dependency of camel-ftp in my Maven setup and added a dependency to commons-net:3.3.
>> 
>> Since this is quite a fundamental bug, it would be great if Camel-FTP would be upgraded to use the current version of commons-net with the next Camel release.
>> 
>> Regards
>> Carsten
> 
> 
> 
> -- 
> Claus Ibsen
> -----------------
> www.camelone.org: The open source integration conference.
> 
> Red Hat, Inc.
> FuseSource is now part of Red Hat
> Email: cibsen@redhat.com
> Web: http://fusesource.com
> Twitter: davsclaus
> Blog: http://davsclaus.com
> Author of Camel in Action: http://www.manning.com/ibsen


Re: Problem with Camel FTP component because of bug in commons-net

Posted by Claus Ibsen <cl...@gmail.com>.
Hi

Ah thanks. We downgraded to 3.1 as that was working well.
Are you sure 3.3 works fine?

On Tue, Jun 18, 2013 at 6:23 PM, Erker, Carsten
<Ca...@akquinet.de> wrote:
> Hi,
>
> I just stumbled upon a bug in Apache Commons Net 3.2 / FTPClient. The bug is known and fixed in Commons Net 3.3: https://issues.apache.org/jira/browse/NET-502
>
> The problem was with the FTP producer, when after putting a file to the server, I got a 5xx error as Camel tries to change back to the current working dir (see FtpOperations.storeFile()).
> This happened due to incorrect parsing of the reply from a PWD in FTPClient.__parsePathname() when getting the current working dir.
>
> For a first work-around I excluded the commons-net:3.2 dependency of camel-ftp in my Maven setup and added a dependency to commons-net:3.3.
>
> Since this is quite a fundamental bug, it would be great if Camel-FTP would be upgraded to use the current version of commons-net with the next Camel release.
>
> Regards
> Carsten



-- 
Claus Ibsen
-----------------
www.camelone.org: The open source integration conference.

Red Hat, Inc.
FuseSource is now part of Red Hat
Email: cibsen@redhat.com
Web: http://fusesource.com
Twitter: davsclaus
Blog: http://davsclaus.com
Author of Camel in Action: http://www.manning.com/ibsen