You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by praveenmeenakshi56 <gi...@git.apache.org> on 2018/04/09 09:14:30 UTC
[GitHub] carbondata pull request #2147: [CARBONDATA-2322] Added fix for data mismatch...
GitHub user praveenmeenakshi56 opened a pull request:
https://github.com/apache/carbondata/pull/2147
[CARBONDATA-2322] Added fix for data mismatch after compaction on Pre-agg with partition
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
NA
- [ ] Any backward compatibility impacted?
NA
- [ ] Document update required?
NA
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
NA
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/praveenmeenakshi56/carbondata defect_compact
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2147.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2147
----
commit f010276bd3dea3f1b7db4b96cff4d8f69496dbf1
Author: praveenmeenakshi56 <pr...@...>
Date: 2018-04-09T09:07:09Z
added fix for data mismatch after compaction on Pre-agg with partition
----
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5327/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4030/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3865/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2147
retest this please
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3664/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2147
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4378/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4873/
---
[GitHub] carbondata pull request #2147: [CARBONDATA-2322] Added fix for data mismatch...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2147#discussion_r181698450
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateListeners.scala ---
@@ -102,7 +102,7 @@ trait CommitHelper {
false
}
} else {
- false
+ true
--- End diff --
can u please add some comments.
---
[GitHub] carbondata pull request #2147: [CARBONDATA-2322] Added fix for data mismatch...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2147#discussion_r181698087
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala ---
@@ -753,10 +753,7 @@ case class CarbonPreAggregateQueryRules(sparkSession: SparkSession) extends Rule
updatedAggExp.head,
name)(alias.exprId, alias.qualifier, Option(alias.metadata), alias.isGenerated)
case alias@Alias(expression, name) =>
- AttributeReference(
- name,
- alias.dataType,
- alias.nullable) (alias.exprId, alias.qualifier, alias.isGenerated)
+ alias
--- End diff --
In case of streaming top level aggregate node , it will always return attribute reference, only in case of aggregate function it will return alias with aggregate expression
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5231/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3684/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3874/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3651/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2147
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4342/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2147
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4382/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2147
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4374/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5084/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4887/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4922/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4918/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3847/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5069/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2147
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4357/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4899/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5104/
---
[GitHub] carbondata pull request #2147: [CARBONDATA-2322] Added fix for data mismatch...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2147
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4912/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3947/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2147
LGTM
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4907/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5157/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2147
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4385/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3689/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/4142/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3676/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2147
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/4367/
---
[GitHub] carbondata pull request #2147: [CARBONDATA-2322] Added fix for data mismatch...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2147#discussion_r182648283
--- Diff: integration/spark-common-test/src/test/scala/org/apache/carbondata/integration/spark/testsuite/preaggregate/TestPreAggCreateCommand.scala ---
@@ -435,7 +435,7 @@ class TestPreAggCreateCommand extends QueryTest with BeforeAndAfterAll {
sql("DESCRIBE FORMATTED PreAggMain_preagg2").show()
}
}
-
+/*
--- End diff --
Ignore this test case for now... Add // TODO
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3697/
---
[GitHub] carbondata issue #2147: [CARBONDATA-2322] Added fix for data mismatch after ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2147
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/5088/
---