You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Qifan Chen (Code Review)" <ge...@cloudera.org> on 2021/06/22 17:32:52 UTC
[Impala-ASF-CR] IMPALA-10754: test overlap min max filters on sorted columns failed during GVO
Qifan Chen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17618
Change subject: IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
......................................................................
IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
This patch addresses the following failure in ubuntu 16.04 dockerised tests:
select straight_join count(a.timestamp_col) from
alltypes_timestamp_col_only a join [SHUFFLE] alltypes_limited b
where a.timestamp_col = b.timestamp_col and b.tinyint_col = 4
aggregation(SUM, NumRuntimeFilteredPages): 58
EXPECTED VALUE:
58
ACTUAL VALUE:
59
OP:
:
In the patch, the result expectation is altered from '==58" to ">57".
Testing:
1). Ran test_overlap_min_max_filters_on_sorted_columns multiple
times under regular and local catalog mode.
Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
---
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17618/1
--
To view, visit http://gerrit.cloudera.org:8080/17618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
Gerrit-Change-Number: 17618
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
[Impala-ASF-CR] IMPALA-10754: test overlap min max filters on sorted columns failed during GVO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17618 )
Change subject: IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
Gerrit-Change-Number: 17618
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 18:18:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10754: test overlap min max filters on sorted columns failed during GVO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17618 )
Change subject: IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
......................................................................
IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
This patch addresses the following failure in ubuntu 16.04 dockerised
test:
select straight_join count(a.timestamp_col) from
alltypes_timestamp_col_only a join [SHUFFLE] alltypes_limited b
where a.timestamp_col = b.timestamp_col and b.tinyint_col = 4
aggregation(SUM, NumRuntimeFilteredPages): 58
EXPECTED VALUE:
58
ACTUAL VALUE:
59
OP:
:
In the patch, the result expectation is altered from "==58" to ">57".
Testing:
1). Ran test_overlap_min_max_filters_on_sorted_columns multiple
times under regular and local catalog mode.
Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
Reviewed-on: http://gerrit.cloudera.org:8080/17618
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
Gerrit-Change-Number: 17618
Gerrit-PatchSet: 5
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10754: test overlap min max filters on sorted columns failed during GVO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17618 )
Change subject: IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7248/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
Gerrit-Change-Number: 17618
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 18:18:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10754: test overlap min max filters on sorted columns failed during GVO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17618 )
Change subject: IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8972/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
Gerrit-Change-Number: 17618
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 17:59:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10754: test overlap min max filters on sorted columns failed during GVO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17618 )
Change subject: IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8971/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
Gerrit-Change-Number: 17618
Gerrit-PatchSet: 1
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 17:55:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10754: test overlap min max filters on sorted columns failed during GVO
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/17618 )
Change subject: IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
......................................................................
IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
This patch addresses the following failure in ubuntu 16.04 dockerised
test:
select straight_join count(a.timestamp_col) from
alltypes_timestamp_col_only a join [SHUFFLE] alltypes_limited b
where a.timestamp_col = b.timestamp_col and b.tinyint_col = 4
aggregation(SUM, NumRuntimeFilteredPages): 58
EXPECTED VALUE:
58
ACTUAL VALUE:
59
OP:
:
In the patch, the result expectation is altered from "==58" to ">57".
Testing:
1). Ran test_overlap_min_max_filters_on_sorted_columns multiple
times under regular and local catalog mode.
Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
---
M testdata/workloads/functional-query/queries/QueryTest/overlap_min_max_filters_on_sorted_columns.test
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/18/17618/3
--
To view, visit http://gerrit.cloudera.org:8080/17618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
Gerrit-Change-Number: 17618
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10754: test overlap min max filters on sorted columns failed during GVO
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17618 )
Change subject: IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
Gerrit-Change-Number: 17618
Gerrit-PatchSet: 4
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Jun 2021 00:20:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10754: test overlap min max filters on sorted columns failed during GVO
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17618 )
Change subject: IMPALA-10754: test_overlap_min_max_filters_on_sorted_columns failed during GVO
......................................................................
Patch Set 3: Code-Review+2
Thanks for fixing this so quickly!
--
To view, visit http://gerrit.cloudera.org:8080/17618
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9eb198dc4e4b0ad1a17696a1d74ff05ac0a436
Gerrit-Change-Number: 17618
Gerrit-PatchSet: 3
Gerrit-Owner: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 22 Jun 2021 18:17:59 +0000
Gerrit-HasComments: No