[jira] Commented: (ABDERA-279) Faulty classloading - unreachable code

["ant elder (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ABDERA-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979694#action_12979694 ] 

ant elder commented on ABDERA-279:
----------------------------------

Thanks Antoine, that does look wrong. Any chance you would provide a fix patch? 

> Faulty classloading - unreachable code
> --------------------------------------
>
>                 Key: ABDERA-279
>                 URL: https://issues.apache.org/jira/browse/ABDERA-279
>             Project: Abdera
>          Issue Type: Bug
>    Affects Versions: 1.1.1
>            Reporter: Antoine Toulme
>
> The Discover class uses this method to get a class:
> {code}
>       private static <T> Class<T> getClass(ClassLoader loader, String spec) {
>         Class<T> c = null;
>         try {
>             c = (Class<T>)loader.loadClass(spec);
>             c = (Class<T>)(c != null ? c : getClass(Discover.class.getClassLoader(), spec));
>         } catch (ClassNotFoundException e) {
>             throw new RuntimeException(e);
>         }
>         return c;
>     }
> {code}
> However the first line inside the try statement will throw a CNF exception if the class cannot be found. As a result, the second line is never executed.
> {code}
> c = (Class<T>)(c != null ? c : getClass(Discover.class.getClassLoader(), spec));
> {code}
> The code executes recursively, which makes things harder. I would recommend changing the way the code is currently written to avoid recursion.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.