You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2018/11/30 02:49:54 UTC
[GitHub] vongosling closed pull request #6: Refactor package.sh to support
building shared library
vongosling closed pull request #6: Refactor package.sh to support building shared library
URL: https://github.com/apache/rocketmq-client-python/pull/6
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/package.sh b/package.sh
index f22d293..404a4f4 100755
--- a/package.sh
+++ b/package.sh
@@ -44,7 +44,7 @@ DEPLOY_BUILD_HOME=${CWD_DIR}/${PACKAGE}
rm -rf ${CWD_DIR}/tmpbuild
mkdir -p ${CWD_DIR}/tmpbuild
cd ${CWD_DIR}/tmpbuild
-if [ $1 = "shared" ]; then
+if [ "$1" = "shared" ]; then
echo "------------Build Client using dynamic library------------"
cmake ${CWD_DIR} -DBoost_USE_STATIC_LIBS=OFF -DROCKETMQ_USE_STATIC_LIBS=OFF
RMQ=$(cat CMakeCache.txt | grep ROCKETMQ_LIBRARIES:FILEPATH= | cut -f2 -d "=")
@@ -66,7 +66,7 @@ cd ${CWD_DIR}
echo "Package Library...."
rm -rf ${DEPLOY_BUILD_HOME}
mkdir -p ${DEPLOY_BUILD_HOME}/lib
-if [ $1 = "shared" ];then
+if [ "$1" = "shared" ];then
echo "Copy librocketmq to package...."
cp -rf ${RMQ} ${DEPLOY_BUILD_HOME}/lib/
#cp -rf /usr/local/lib/libboost_python.*.so.* ${DEPLOY_BUILD_HOME}/lib/
@@ -77,7 +77,7 @@ cp -rf ${CWD_DIR}/doc ${DEPLOY_BUILD_HOME}/
cp -rf ${CWD_DIR}/changelog ${DEPLOY_BUILD_HOME}/
-cd ${CWD_DIR} && tar -cvzf ./${PACKAGE}-${VERSION}.tar.gz ./${VERSION} >/dev/null 2>&1
+cd ${CWD_DIR} && tar -cvzf ./${PACKAGE}-${VERSION}.tar.gz ./${PACKAGE} >/dev/null 2>&1
rm -rf ${DEPLOY_BUILD_HOME}
# # ##====================================================================
cd ${CWD_DIR}/tmpbuild
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services