You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/04/02 14:09:23 UTC
Review Request: Cloudstack-701
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/
-----------------------------------------------------------
Review request for cloudstack and Abhinandan Prateek.
Description
-------
Cloudstack-701: Support for non contiguous vlan ranges.
Diffs
-----
api/src/com/cloud/network/NetworkService.java ab6d7bf
api/src/com/cloud/network/PhysicalNetwork.java 343a2b1
api/src/org/apache/cloudstack/api/ApiConstants.java c518830
api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 8dbf081
server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
Diff: https://reviews.apache.org/r/10238/diff/
Testing
-------
Need to test this on latest master.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by bharat kumar <bh...@citrix.com>.
> On April 8, 2013, 9:36 p.m., Likitha Shetty wrote:
> > server/src/com/cloud/network/NetworkServiceImpl.java, line 2377
> > <https://reviews.apache.org/r/10238/diff/2/?file=277888#file277888line2377>
> >
> > Please handle the following 2 corner cases where admin user tries to shrink the existing vnet ranges
> > 1. New start vnet is equal to the start vnet of the existing range and the new end vnet is less than the existing end vnet
> > 2. New start vnet is greater than the start vnet of the existing range and the new end vnet is equal to the existing end vnet
The error message is incorrect, It is not about trying to shrink the vlan range. Forgot to remove the error message from previous code. Thanks for pointing this out. Fixed it.
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review18795
-----------------------------------------------------------
On April 4, 2013, 12:36 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 12:36 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java ab6d7bf
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java c518830
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
> server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
> server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
RE: Review Request: Cloudstack-701 Support for non contiguous vlan
ranges.
Posted by Likitha Shetty <li...@citrix.com>.
Yes, we don't allow admin to shrink a guest VLAN range. The 2 scenarios I mentioned are negative test cases that need to be handled.
Thank you,
Likitha
>-----Original Message-----
>From: Pranav Saxena
>Sent: Monday, April 08, 2013 4:35 PM
>To: dev@cloudstack.apache.org; Likitha Shetty; Abhinandan Prateek
>Cc: cloudstack; Bharat Kumar
>Subject: RE: Review Request: Cloudstack-701 Support for non contiguous vlan
>ranges.
>
>The FS says that the feature only deals with extending the VLAN range when
>calling the update physical network API with the new VLAN range parameter . So
>, why would shrinking a VLAN range be a valid use case for it ? When you have
>already given a VLAN Range which when gets exhausted calls the need for this
>feature perhaps. I might not be 100 % correct but this is what I remember about
>the discussion I had with Abhi and Bharat .
>
>-----Original Message-----
>From: Likitha Shetty [mailto:noreply@reviews.apache.org] On Behalf Of Likitha
>Shetty
>Sent: Tuesday, April 09, 2013 3:06 AM
>To: Abhinandan Prateek
>Cc: cloudstack; Bharat Kumar; Likitha Shetty
>Subject: Re: Review Request: Cloudstack-701 Support for non contiguous vlan
>ranges.
>
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/10238/#review18795
>-----------------------------------------------------------
>
>
>
>server/src/com/cloud/network/NetworkServiceImpl.java
><https://reviews.apache.org/r/10238/#comment39235>
>
> Please handle the following 2 corner cases where admin user tries to shrink
>the existing vnet ranges
> 1. New start vnet is equal to the start vnet of the existing range and the new
>end vnet is less than the existing end vnet
> 2. New start vnet is greater than the start vnet of the existing range and the
>new end vnet is equal to the existing end vnet
>
>
>- Likitha Shetty
>
>
>On April 4, 2013, 12:36 p.m., bharat kumar wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/10238/
>> -----------------------------------------------------------
>>
>> (Updated April 4, 2013, 12:36 p.m.)
>>
>>
>> Review request for cloudstack and Abhinandan Prateek.
>>
>>
>> Description
>> -------
>>
>> Cloudstack-701: Support for non contiguous vlan ranges.
>>
>>
>> Diffs
>> -----
>>
>> api/src/com/cloud/network/NetworkService.java ab6d7bf
>> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
>> api/src/org/apache/cloudstack/api/ApiConstants.java c518830
>>
>api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNe
>tworkCmd.java 06cf38d
>> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
>> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
>> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
>> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
>> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java
>ae00bf2
>> server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
>> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
>> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
>> server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
>> server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
>> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-
>CREATION
>> server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
>> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>>
>> Diff: https://reviews.apache.org/r/10238/diff/
>>
>>
>> Testing
>> -------
>>
>> Tested on latest master.
>>
>>
>> Thanks,
>>
>> bharat kumar
>>
>>
RE: Review Request: Cloudstack-701 Support for non contiguous vlan
ranges.
Posted by Pranav Saxena <pr...@citrix.com>.
The FS says that the feature only deals with extending the VLAN range when calling the update physical network API with the new VLAN range parameter . So , why would shrinking a VLAN range be a valid use case for it ? When you have already given a VLAN Range which when gets exhausted calls the need for this feature perhaps. I might not be 100 % correct but this is what I remember about the discussion I had with Abhi and Bharat .
-----Original Message-----
From: Likitha Shetty [mailto:noreply@reviews.apache.org] On Behalf Of Likitha Shetty
Sent: Tuesday, April 09, 2013 3:06 AM
To: Abhinandan Prateek
Cc: cloudstack; Bharat Kumar; Likitha Shetty
Subject: Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review18795
-----------------------------------------------------------
server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10238/#comment39235>
Please handle the following 2 corner cases where admin user tries to shrink the existing vnet ranges
1. New start vnet is equal to the start vnet of the existing range and the new end vnet is less than the existing end vnet
2. New start vnet is greater than the start vnet of the existing range and the new end vnet is equal to the existing end vnet
- Likitha Shetty
On April 4, 2013, 12:36 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 12:36 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java ab6d7bf
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java c518830
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
> server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
> server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review18795
-----------------------------------------------------------
server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10238/#comment39235>
Please handle the following 2 corner cases where admin user tries to shrink the existing vnet ranges
1. New start vnet is equal to the start vnet of the existing range and the new end vnet is less than the existing end vnet
2. New start vnet is greater than the start vnet of the existing range and the new end vnet is equal to the existing end vnet
- Likitha Shetty
On April 4, 2013, 12:36 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 12:36 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java ab6d7bf
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java c518830
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
> server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
> server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by bharat kumar <bh...@citrix.com>.
> On April 9, 2013, 6:17 p.m., Likitha Shetty wrote:
> > All guest vlan ranges belonging to one physical network are being updated in the same column. This would mean there is no way to uniquely identify or operate on each of the individual ranges.
> > Shouldn't we instead have a separate entry for each range in the physical_network table? Or maybe have a new table to hold the guest vlan ranges where they are mapped to the corresponding physical network?
we can get the vlanranges by splitting over the semicolon. If you want to do any individual operations on a vlan range you can use the op_dc_vnet_alloc table.
I think rather than operating on the vlan range it is better to operate on individual vlan.
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review18866
-----------------------------------------------------------
On April 9, 2013, 3 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 3 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java ab6d7bf
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java c518830
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
> server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
> server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review18866
-----------------------------------------------------------
All guest vlan ranges belonging to one physical network are being updated in the same column. This would mean there is no way to uniquely identify or operate on each of the individual ranges.
Shouldn't we instead have a separate entry for each range in the physical_network table? Or maybe have a new table to hold the guest vlan ranges where they are mapped to the corresponding physical network?
- Likitha Shetty
On April 9, 2013, 3 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 3 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java ab6d7bf
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java c518830
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
> server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
> server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by Abhinandan Prateek <ap...@apache.org>.
> On April 12, 2013, 9:53 a.m., Abhinandan Prateek wrote:
> > Ship It!
The patch does not apply, can you resubmit after checking it.
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review19060
-----------------------------------------------------------
On April 9, 2013, 3 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 3 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java ab6d7bf
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java c518830
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
> server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
> server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by bharat kumar <bh...@citrix.com>.
> On April 12, 2013, 9:53 a.m., Abhinandan Prateek wrote:
> > Ship It!
>
> Abhinandan Prateek wrote:
> The patch does not apply, can you resubmit after checking it.
uploaded the new diff
- bharat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review19060
-----------------------------------------------------------
On April 16, 2013, 2:53 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 2:53 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java 066009b
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java 37cb59f
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java cfe0e00
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java c9ae854
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java c2038e5
> server/src/com/cloud/network/NetworkServiceImpl.java 70d1d0d
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/test/com/cloud/network/MockNetworkManagerImpl.java 9042f03
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java 3a585ce
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by Abhinandan Prateek <ap...@apache.org>.
> On April 12, 2013, 9:53 a.m., Abhinandan Prateek wrote:
> > Ship It!
>
> Abhinandan Prateek wrote:
> The patch does not apply, can you resubmit after checking it.
>
> bharat kumar wrote:
> uploaded the new diff
committed
- Abhinandan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review19060
-----------------------------------------------------------
On April 16, 2013, 2:53 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 2:53 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java 066009b
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java 37cb59f
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java cfe0e00
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java c9ae854
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java c2038e5
> server/src/com/cloud/network/NetworkServiceImpl.java 70d1d0d
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/test/com/cloud/network/MockNetworkManagerImpl.java 9042f03
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java 3a585ce
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review19060
-----------------------------------------------------------
Ship it!
Ship It!
- Abhinandan Prateek
On April 9, 2013, 3 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 9, 2013, 3 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java ab6d7bf
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java c518830
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
> server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
> server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-701 Support for non contiguous vlan
ranges.
Posted by Prasanna Santhanam <ts...@apache.org>.
On Tue, Apr 16, 2013 at 02:53:43PM +0000, bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 16, 2013, 2:53 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs (updated)
> -----
>
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
Thanks for taking the time to write a marvin test. But please ensure
you've run it against the simulator or an environment the test is
suitable for. Also pay attention to the existing examples in other
areas - there's some good libraries included in Marvin to simplify
test case writing.
In your case I had to fix up the test to run as it had SyntaxErrors
in it.
--
Prasanna.,
------------------------
Powered by BigRock.com
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/
-----------------------------------------------------------
(Updated April 16, 2013, 2:53 p.m.)
Review request for cloudstack and Abhinandan Prateek.
Description
-------
Cloudstack-701: Support for non contiguous vlan ranges.
Diffs (updated)
-----
api/src/com/cloud/network/NetworkService.java 066009b
api/src/com/cloud/network/PhysicalNetwork.java a2044a6
api/src/org/apache/cloudstack/api/ApiConstants.java 37cb59f
api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
server/src/com/cloud/api/ApiResponseHelper.java cfe0e00
server/src/com/cloud/configuration/ConfigurationManagerImpl.java c9ae854
server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java c2038e5
server/src/com/cloud/network/NetworkServiceImpl.java 70d1d0d
server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
server/test/com/cloud/network/MockNetworkManagerImpl.java 9042f03
server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
server/test/com/cloud/vpc/MockNetworkManagerImpl.java 3a585ce
test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
Diff: https://reviews.apache.org/r/10238/diff/
Testing
-------
Tested on latest master.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/
-----------------------------------------------------------
(Updated April 9, 2013, 3 p.m.)
Review request for cloudstack and Abhinandan Prateek.
Changes
-------
Fixed a few corner cases and improved exception handling.
Description
-------
Cloudstack-701: Support for non contiguous vlan ranges.
Diffs (updated)
-----
api/src/com/cloud/network/NetworkService.java ab6d7bf
api/src/com/cloud/network/PhysicalNetwork.java a2044a6
api/src/org/apache/cloudstack/api/ApiConstants.java c518830
api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
Diff: https://reviews.apache.org/r/10238/diff/
Testing
-------
Tested on latest master.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review18684
-----------------------------------------------------------
Good test coverage included. Thanks for that.
- Chip Childers
On April 4, 2013, 12:36 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 12:36 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java ab6d7bf
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java c518830
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
> server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
> server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by Abhinandan Prateek <ap...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/#review18773
-----------------------------------------------------------
server/src/com/cloud/network/NetworkServiceImpl.java
<https://reviews.apache.org/r/10238/#comment39190>
Convert this to a for loop. (limits scope for i)
- Abhinandan Prateek
On April 4, 2013, 12:36 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10238/
> -----------------------------------------------------------
>
> (Updated April 4, 2013, 12:36 p.m.)
>
>
> Review request for cloudstack and Abhinandan Prateek.
>
>
> Description
> -------
>
> Cloudstack-701: Support for non contiguous vlan ranges.
>
>
> Diffs
> -----
>
> api/src/com/cloud/network/NetworkService.java ab6d7bf
> api/src/com/cloud/network/PhysicalNetwork.java a2044a6
> api/src/org/apache/cloudstack/api/ApiConstants.java c518830
> api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
> server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
> server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
> server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
> server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
> server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
> server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
> server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
> server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
> server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
> server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
> server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
> test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/10238/diff/
>
>
> Testing
> -------
>
> Tested on latest master.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/
-----------------------------------------------------------
(Updated April 4, 2013, 12:36 p.m.)
Review request for cloudstack and Abhinandan Prateek.
Description
-------
Cloudstack-701: Support for non contiguous vlan ranges.
Diffs
-----
api/src/com/cloud/network/NetworkService.java ab6d7bf
api/src/com/cloud/network/PhysicalNetwork.java a2044a6
api/src/org/apache/cloudstack/api/ApiConstants.java c518830
api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
Diff: https://reviews.apache.org/r/10238/diff/
Testing (updated)
-------
Tested on latest master.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/
-----------------------------------------------------------
(Updated April 4, 2013, 12:35 p.m.)
Review request for cloudstack and Abhinandan Prateek.
Description
-------
Cloudstack-701: Support for non contiguous vlan ranges.
Diffs (updated)
-----
api/src/com/cloud/network/NetworkService.java ab6d7bf
api/src/com/cloud/network/PhysicalNetwork.java a2044a6
api/src/org/apache/cloudstack/api/ApiConstants.java c518830
api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 1526fb0
server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
Diff: https://reviews.apache.org/r/10238/diff/
Testing
-------
Need to test this on latest master.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-701 Support for non contiguous vlan ranges.
Posted by bharat kumar <bh...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10238/
-----------------------------------------------------------
(Updated April 2, 2013, 12:11 p.m.)
Review request for cloudstack and Abhinandan Prateek.
Summary (updated)
-----------------
Cloudstack-701 Support for non contiguous vlan ranges.
Description
-------
Cloudstack-701: Support for non contiguous vlan ranges.
Diffs
-----
api/src/com/cloud/network/NetworkService.java ab6d7bf
api/src/com/cloud/network/PhysicalNetwork.java 343a2b1
api/src/org/apache/cloudstack/api/ApiConstants.java c518830
api/src/org/apache/cloudstack/api/command/admin/network/UpdatePhysicalNetworkCmd.java 06cf38d
server/src/com/cloud/api/ApiResponseHelper.java 64be7f8
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 8dbf081
server/src/com/cloud/dc/dao/DataCenterVnetDao.java 79e91c4
server/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java 5ded0f4
server/src/com/cloud/network/ExternalFirewallDeviceManagerImpl.java ae00bf2
server/src/com/cloud/network/NetworkServiceImpl.java 4eb620c
server/src/com/cloud/network/dao/PhysicalNetworkVO.java e5ffcfb
server/src/com/cloud/network/guru/GuestNetworkGuru.java 9c0205a
server/src/com/cloud/resource/ResourceManagerImpl.java 82bca51
server/test/com/cloud/network/MockNetworkManagerImpl.java 6da48ec
server/test/com/cloud/network/UpdatePhysicalNetworkTest.java PRE-CREATION
server/test/com/cloud/vpc/MockNetworkManagerImpl.java ead0051
test/integration/smoke/test_non_contigiousvlan.py PRE-CREATION
Diff: https://reviews.apache.org/r/10238/diff/
Testing
-------
Need to test this on latest master.
Thanks,
bharat kumar