You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Sven Meier (JIRA)" <ji...@apache.org> on 2013/01/31 21:47:12 UTC

[jira] [Resolved] (WICKET-5019) Handling of NO_MINIFIED_NAME in PackageResourceReference#internalGetMinifiedName()

     [ https://issues.apache.org/jira/browse/WICKET-5019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sven Meier resolved WICKET-5019.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 6.6.0
         Assignee: Sven Meier

Thanks.
                
> Handling of NO_MINIFIED_NAME in PackageResourceReference#internalGetMinifiedName()   
> -------------------------------------------------------------------------------------
>
>                 Key: WICKET-5019
>                 URL: https://issues.apache.org/jira/browse/WICKET-5019
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 6.5.0
>            Reporter: Roland Foerther
>            Assignee: Sven Meier
>            Priority: Minor
>             Fix For: 6.6.0
>
>
> The Value NO_MINIFIED_NAME is not handled correctly as entry in the MINIFIED_NAMES_CACHE in PackageResourceReference#internalGetMinifiedName()   
> 	private String internalGetMinifiedName()
> 	{
> 		String minifiedName = MINIFIED_NAMES_CACHE.get(this);
> 		if (minifiedName != null && minifiedName != NO_MINIFIED_NAME)
> 		{                                                        ^^^^^^^
> 			return minifiedName;
>                 }
>                 ...
> You should remove the condition "minifiedName != NO_MINIFIED_NAME" here to leverage the 
> MINIFIED_NAMES_CACHE for NO_MINIFIED_NAME cache entries. Otherwise you always run into the resource resolving code if there is no minified resource.
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira