You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Qianlin Xia <qi...@microsoft.com> on 2015/04/14 12:44:36 UTC
Re: Review Request 29091: Patch for KAFKA-1646
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated April 14, 2015, 10:44 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Patch for KAFKA-1646
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Commit to local for 1646 fix
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/server/KafkaConfig.scala 0a288f986efc7afba9aad2df70261a9c46829db6
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Improve 1646 fix by add log.preallocate
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated April 15, 2015, 1:45 a.m.)
Review request for kafka.
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Kafka 1646 fix update - Do not do flush when trim
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/server/KafkaConfig.scala 0a288f986efc7afba9aad2df70261a9c46829db6
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Improve 1646 fix by add log.preallocate
Posted by Jay Kreps <bo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/#review80031
-----------------------------------------------------------
This patch is looking really good. One minor issue but otherwise good to go.
core/src/main/scala/kafka/log/FileMessageSet.scala
<https://reviews.apache.org/r/29091/#comment129783>
Forcing a flush here will block all writes to the segment during a log roll() (potentially for upward of 30 seconds). I don't actually think this flush is needed since we have a background process which handles the segment flush. I think trim() should just trim the excess bytes and the close() can still force the flush.
core/src/main/scala/kafka/log/LogConfig.scala
<https://reviews.apache.org/r/29091/#comment129784>
- Jay Kreps
On April 14, 2015, 10:54 a.m., Qianlin Xia wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29091/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 10:54 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1646
> https://issues.apache.org/jira/browse/KAFKA-1646
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Commit to local for 1646 fix
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
> core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
> core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b
> core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
> core/src/main/scala/kafka/server/KafkaConfig.scala 0a288f986efc7afba9aad2df70261a9c46829db6
> core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
>
> Diff: https://reviews.apache.org/r/29091/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qianlin Xia
>
>
Re: Review Request 29091: Improve 1646 fix by add log.preallocate
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated April 14, 2015, 10:54 a.m.)
Review request for kafka.
Summary (updated)
-----------------
Improve 1646 fix by add log.preallocate
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Commit to local for 1646 fix
Diffs (updated)
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/server/KafkaConfig.scala 0a288f986efc7afba9aad2df70261a9c46829db6
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia
Re: Review Request 29091: Patch for KAFKA-1646
Posted by Qianlin Xia <qi...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29091/
-----------------------------------------------------------
(Updated April 14, 2015, 10:46 a.m.)
Review request for kafka.
Changes
-------
Add log.preallocation for Kafka-1646 fix
Bugs: KAFKA-1646
https://issues.apache.org/jira/browse/KAFKA-1646
Repository: kafka
Description (updated)
-------
Add log.preallocation for Kafka-1646 fix
Diffs
-----
core/src/main/scala/kafka/log/FileMessageSet.scala e1f8b979c3e6f62ea235bd47bc1587a1291443f9
core/src/main/scala/kafka/log/Log.scala 46df8d99d977a3b010a9b9f4698187fa9bfb2498
core/src/main/scala/kafka/log/LogConfig.scala 18c86fed5efc765f9b059775988cc83ef0ef3c3b
core/src/main/scala/kafka/log/LogSegment.scala 0d6926ea105a99c9ff2cfc9ea6440f2f2d37bde8
core/src/main/scala/kafka/server/KafkaConfig.scala 0a288f986efc7afba9aad2df70261a9c46829db6
core/src/main/scala/kafka/utils/Utils.scala a89b0463685e6224d263bc9177075e1bb6b93d04
Diff: https://reviews.apache.org/r/29091/diff/
Testing
-------
Thanks,
Qianlin Xia