You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by va...@apache.org on 2020/01/08 22:02:29 UTC
[camel-kafka-connector] 01/02: Minor naming and source checkstyle
fixes.
This is an automated email from the ASF dual-hosted git repository.
valdar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel-kafka-connector.git
commit c5e48ad839c278f7e027d738c120af7d48cf2e17
Author: Andrea Tarocchi <an...@gmail.com>
AuthorDate: Mon Dec 30 23:29:19 2019 +0100
Minor naming and source checkstyle fixes.
---
.../org/apache/camel/kafkaconnector/converters/S3ObjectConverter.java | 2 +-
.../apache/camel/kafkaconnector/converters/S3ObjectSerializer.java | 4 ++--
.../java/org/apache/camel/kafkaconnector/CamelSourceTaskTest.java | 4 ++--
.../src/test/java/org/apache/camel/kafkaconnector/DataFormatTest.java | 1 -
4 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectConverter.java b/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectConverter.java
index a74eb5d..b1ad0ac 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectConverter.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectConverter.java
@@ -28,7 +28,7 @@ public class S3ObjectConverter implements Converter {
private final S3ObjectSerializer serializer = new S3ObjectSerializer();
@Override
- public void configure(Map<String, ?> arg0, boolean arg1) {
+ public void configure(Map<String, ?> configs, boolean isKey) {
}
@Override
diff --git a/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectSerializer.java b/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectSerializer.java
index b55579e..f4ceae5 100644
--- a/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectSerializer.java
+++ b/core/src/main/java/org/apache/camel/kafkaconnector/converters/S3ObjectSerializer.java
@@ -45,8 +45,8 @@ public class S3ObjectSerializer implements Serializer<S3ObjectInputStream> {
while ((nRead = is.read(byteArray, 0, byteArray.length)) != -1) {
buffer.write(byteArray, 0, nRead);
}
- } catch (IOException e1) {
- LOG.warn("I/O error while serializing data from topic {}: {}", topic, e1.getMessage(), e1);
+ } catch (IOException e) {
+ LOG.warn("I/O error while serializing data from topic {}: {}", topic, e.getMessage(), e);
}
return buffer.toByteArray();
diff --git a/core/src/test/java/org/apache/camel/kafkaconnector/CamelSourceTaskTest.java b/core/src/test/java/org/apache/camel/kafkaconnector/CamelSourceTaskTest.java
index f2a8aa4..b8318db 100644
--- a/core/src/test/java/org/apache/camel/kafkaconnector/CamelSourceTaskTest.java
+++ b/core/src/test/java/org/apache/camel/kafkaconnector/CamelSourceTaskTest.java
@@ -193,8 +193,8 @@ public class CamelSourceTaskTest {
}
} while (poll == null && retries > 0);
- assertTrue("Received messages are: "+poll.size()+", expected between 1 and 2.", poll.size() >= 1);
- assertTrue("Received messages are: "+poll.size()+", expected between 1 and 2.", poll.size() <= 2);
+ assertTrue("Received messages are: " + poll.size() + ", expected between 1 and 2.", poll.size() >= 1);
+ assertTrue("Received messages are: " + poll.size() + ", expected between 1 and 2.", poll.size() <= 2);
camelSourceTask.stop();
}
diff --git a/core/src/test/java/org/apache/camel/kafkaconnector/DataFormatTest.java b/core/src/test/java/org/apache/camel/kafkaconnector/DataFormatTest.java
index 2830b47..a71b407 100644
--- a/core/src/test/java/org/apache/camel/kafkaconnector/DataFormatTest.java
+++ b/core/src/test/java/org/apache/camel/kafkaconnector/DataFormatTest.java
@@ -80,7 +80,6 @@ public class DataFormatTest {
DefaultCamelContext dcc = new DefaultCamelContext();
CamelMainSupport cms = new CamelMainSupport(props, "direct://start", "log://test", null, "hl7", dcc);
-
HL7DataFormat hl7df = new HL7DataFormat();
hl7df.setValidate(false);
dcc.getRegistry().bind("hl7", hl7df);