[GitHub] cloud-fan commented on a change in pull request #9206: [SPARK-11235] [network] Add ability to stream data using network lib.

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #9206: [SPARK-11235] [network] Add ability to stream data using network lib.
URL: https://github.com/apache/spark/pull/9206#discussion_r246732354
 
 

 ##########
 File path: network/common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
 ##########
 @@ -50,6 +55,8 @@
 
   private final Map<Long, RpcResponseCallback> outstandingRpcs;
 
+  private final Queue<StreamCallback> streamCallbacks;
 
 Review comment:
   Sorry to comment on this very old thread.
   
   I get it that this can be a queue, but I don't get it why this can't be a `Map<StreamId, StreamCallback>`. Is it for performance concerns?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org